Julius: Crash on clicking "visit yoyr advisors".

[crudelios]

Every now and then clicking the "advisors" button (the one at the sidebar, not the menu) causes the game to immediately crash. The game will keep crashing every time I click the button until I select a specific advisor from the menu, then the button starts working again.

I haven't had the time to study the code and my main PC fried today so I'm limited in resources, but I suspect that some "advisor id" is being set a bogus value that is out of bounds, and that value is saved to c3.inf. This may in no small part be due to the fact that my c3.inf is load and shared between different builds and operating systems.

Still, I believe sanity checking the id of the last visitor advisor to only accept valid values could prevent these crashes.

[crudelios]

Case in note: I will eventually fix this.

[jdmillard]

I tried to duplicate this issue, but I couldn't. Let me know if you detect a pattern in what was happening before the crash and I'll give it another shot!

[crudelios]

My pattern was to constantly rebuild Julius in multiple platforms, and still it only happened twice in the course of two months.

So it's fairly rare...

[bvschaik]

I have managed to reproduce this: remove c3.inf, start the game, click the button. Voila. Fix incoming in a couple of minutes 😉

[jdmillard]

Oh nice!

[crudelios]

Humm I don't think I ever actually lost c3.inf... but if the game crashes again even with the fix, I'll let you know :)