Julia: Switch unicode tests to use testsets

Created on 7 Oct 2016  Â·  8Comments  Â·  Source: JuliaLang/julia

Ping @StefanKarpinski if you have questions.

Hacktoberfest good first issue test unicode

Most helpful comment

I will, despite my snarky Fry meme, do what I can to answer any questions. Don't hesitate to ask.

All 8 comments

fry squinty eyes

Hi,
I can work on this issue, if no one else had started it yet

Wonderful! It's all you :)

On Tue, Oct 11, 2016, 4:00 PM lacemaker [email protected] wrote:

Hi,
I can work on this issue, if no one else had started it yet

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JuliaLang/julia/issues/18829#issuecomment-253072162,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyk4951MfDLExAdFlwMlXJgCUyz1chUks5qzBUGgaJpZM4KQrkh
.

I will, despite my snarky Fry meme, do what I can to answer any questions. Don't hesitate to ask.

@StefanKarpinski it's ok, I like Futurama :)
For now issue seems to be quite clear - I need to change these tests: https://github.com/latticetower/julia/tree/master/test/unicode - to use @testset macro for more fancier look and tests grouping - please correct me if I got something wrong :)

@latticetower you've got it. Check out test/math.jl for examples of what this can look like. We're happy to give feedback and help you revise the PR, so don't hesitate to open a WIP one :).

@kshyatt but I could do it tomorrow evening (it's now 2 a.m. at local time and I have to wake up at 7 a.m.)

We're not in any position to put deadlines on people doing unpaid open source work – whenever you can will be absolutely lovely :)

Was this page helpful?
0 / 5 - 0 ratings