Jsoneditor: Error when clicking a navigationBar path link

[wanderg84]

https://github.com/josdejong/jsoneditor/commit/181140f733baddd2e643e18cf6f1fe1d516acb27#diff-9fd481e566a0f24de9121c0320b1503bL219

• Missing null check in above commit
• An error occurs if there is no 'frame' param.

console log :
ContextMenu.js:209 Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined
at ContextMenu.webpackJsonp../node_modules/jsoneditor/src/js/ContextMenu.js.ContextMenu.show (ContextMenu.js:209)
at HTMLSpanElement.sepEl.onclick (TreePath.js:62)

[josdejong]

Thanks for reporting @wander84, that's a bug.

@meirotstein do you have an idea where this can originate from? It did work in the past.

[meirotstein]

@josdejong I will have a look

[meirotstein]

it is still working...
@wanderg84 can u please provide steps for reproduce?
thanks!

[josdejong]

@meirotstein it happens when you click the triangle between two names:

This should open a dropdown with all properties in the object, but it gives this error in the console:

Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined
    at ContextMenu.show (jsoneditor.js:32922)
    at HTMLSpanElement.sepEl.onclick (jsoneditor.js:35442)

[josdejong]

Ah, I think I caused this error after refactoring the ContextMenu some time ago. ContextMenu.show now requires a second argument in TreePath.js on line 62: menu.show(sepEl);. I will look into it soon (until you beat me Meir ;) )

[josdejong]

@meirotstein I managed to fix it, see https://github.com/josdejong/jsoneditor/commit/67ef58bef3ce199777428c0dd78bca14f59671e1.

[meirotstein]

@josdejong cool! nice fix!

[josdejong]

yeah, well, I should have tested better when changing the ContextMenu. It was changed from being relatively positioned to being absolutely positioned.

[josdejong]

Should be fixed now in v5.25.0

[wanderg84]

Thank you for your quick fix!