Js-ipfs: unpkg.com CDN serves incorrect version of IPFS dist files

[witten]

• Version: Any
• Platform: Linux flux 4.2.0-23-generic #28~14.04.1-Ubuntu SMP Thu Dec 31 13:40:42 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux (Firefox 57.0.1)
• Subsystem: n/a

Severity: Medium

Description:

When fetching either minified or unminified dist versions of js-ipfs from unpkg.com, the previous release from the version requested is returned.

Steps to reproduce the error:

GET https://unpkg.com/[email protected]/dist/index.js contains module.exports = {"name":"ipfs","version":"0.27.4" ...

GET https://unpkg.com/[email protected]/dist/index.js contains module.exports = {"name":"ipfs","version":"0.27.3" ...

GET https://unpkg.com/[email protected]/dist/index.js contains module.exports = {"name":"ipfs","version":"0.27.2" ...

You get the idea..

This is confusing, and could lead to developers getting a different version of js-ipfs than they're expecting, inaccurate bug reports, etc.

[mkg20001]

I think this is because the version gets bumped after the minification by aegir.

[witten]

That would do it. Might be good to change that ordering, as I can foresee folks reporting their ipfs.version() in bug reports or other issues, and inadvertently providing the incorrect version. I know I've already done that at least once.

[daviddias]

Thanks for reporting this bug @witten. Seems that aegir got these steps mixed up. @VictorBjelkholm could you look into this? Thank you!

[daviddias]

Moving this one to aegir -- https://github.com/ipfs/aegir/issues/208