Js-cookie: Why is the api function responsible for read and write?

[nanndemoiikara]

Why is the api function responsible for read and write?
api function any intention to change responsibility depending on the number of arguments?

[FagnerMartinsBrack]

For the Public API, it makes no difference, you still have read and write methods. Internally, it uses the same function for the purpose of reducing the byte size and allow the code to be GZipped around the 900 bytes target, as stated in the README as a feature.

This is a compromise between "Clean Code"/"Clean Architecture"/"SOLID" vs "100% code coverage + downloadable bytes". Ideally, we would want "Clean Code"/"Clean Architecture"/"SOLID" + "100% coverage", unfortunately, we would have to trade "downloadable byte size", so we're making a compromise.

There's no silver bullet.

Given this is a very small and focused project that serves a single purpose (create some sense to the document.cookie API), and is used in a lot of websites, we believe it's a fair compromise to make.

[carhartl]

It is also due to heritage of once being _jquery-cookie_. In jQuery back then it was a common pattern to have this kind of overload for read + write operations.

[FagnerMartinsBrack]

An interesting side-effect of this is https://github.com/js-cookie/js-cookie/issues/417.

[FagnerMartinsBrack]

I don't think there's anything we can act on here. Closing then...

[nanndemoiikara]

@FagnerMartinsBrack

Thank you for answering.