Joss-reviews: [PRE REVIEW]: Thermosteam: BioSTEAM's Premier Thermodynamic Engine

Created on 17 Sep 2020  Â·  28Comments  Â·  Source: openjournals/joss-reviews

Submitting author: @yoelcortes (Yoel Cortes-Pena)
Repository: https://github.com/BioSTEAMDevelopmentGroup/thermosteam
Version: 0.20.26
Editor: @kyleniemeyer
Reviewers: @decaluwe, @fwitte
Managing EiC: Kyle Niemeyer

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @yoelcortes. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @kyleniemeyer.

@yoelcortes if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
Python pre-review

Most helpful comment

Hi @kyleniemeyer,
I would be happy to review the paper.
Best

All 28 comments

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

PDF failed to compile for issue #2679 with the following error:

Can't find any papers to compile :-(

Failed to discover a Statement of need section in paper

Hey @openjournals/dev, I can see the paper in the docs/paper directory in the repo (https://github.com/BioSTEAMDevelopmentGroup/thermosteam/tree/master/docs/paper), any idea why whedon can't find it?

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=3.48 s (29.6 files/s, 16394.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             7            640              0          30104
Python                          81           2786           7106          11550
Jupyter Notebook                 4              0           4035            383
TeX                              1              8              0             83
Markdown                         1              9              0             72
YAML                             3              7              1             60
reStructuredText                 2             29             20             40
DOS Batch                        1              8              1             26
RobotFramework                   1              0              0             10
make                             1              4              7              9
INI                              1              0              0              8
-------------------------------------------------------------------------------
SUM:                           103           3491          11170          42345
-------------------------------------------------------------------------------


Statistical information for the repository '2679' was gathered on 2020/09/17.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Yalin Li                         4          1224            167            1.99
Yoel                            90         11999          22919           50.00
unknown                         12         32861            670           48.01

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Yalin Li                    150           12.3          3.6                4.00
Yoel                      21292          177.4          3.2                8.54

Hi @yoelcortes, thanks for your submission to JOSS! We'll use this issue to identify reviewers and resolve any technical issues (like our friendly bot not being able to find the paper).

I will be serving as editor for this; I have a few potential reviewers in mind, but any suggestions you have are also welcome.

@whedon assign @kyleniemeyer as editor

OK, the editor is @kyleniemeyer

Hey @bryanwweber @decaluwe would one of you be interested in reviewing this for JOSS?

@whedon generate pdf

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

@kyleniemeyer, thanks for picking this up as the editor. I think both potential reviewers are excellent choices. They both have some chemistry and engineering in their background. Let me know if there is anything I can help with. Thanks!

Happy to!

Steven

Sent from my iPhone

On Sep 16, 2020, at 8:20 PM, Kyle Niemeyer notifications@github.com wrote:


Hey @bryanwweber @decaluwe would one of you be interested in reviewing this for JOSS?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks @xuanxu for fixing the paper issue, and thanks @decaluwe!

@whedon add @decaluwe as reviewer

OK, @decaluwe is now a reviewer

:wave: @kyleniemeyer - it looks like this submission is still waiting on you to find a second reviewer before moving forward?

Hi @arosen93, would you be interested in reviewing this submission? Thanks!

@kyleniemeyer -- thanks for reaching out. Seems like a cool package and normally would be up my alley to review, but unfortunately I don't have the time to provide a thorough review right now.

Hi @fwitte, would you be interested in reviewing this submission for JOSS? Thank you!

@kyleniemeyer, thanks for managing the requests to review. Would reaching out to another reviewer soon be a good idea? Thanks!

Hi @kyleniemeyer,
the notification only arrived just now. I'll quickly check, if this fits my scope and give you a feedback as soon as possible.
Best regards
Edit: Actually it was the notification of yoelcortes latest comment, any idea, why yours did not reach? Notification on mention is turned on...

Hi @kyleniemeyer,
I would be happy to review the paper.
Best

@whedon add @fwitte as reviewer

Thanks @fwitte!

OK, @fwitte is now a reviewer

OK, with two reviewers set, I will now start the review issue.

@whedon start review

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2814.

Was this page helpful?
0 / 5 - 0 ratings