Joss-reviews: [REVIEW]: The Experiment Factory: Reproducible Experiment Containers

Created on 22 Dec 2017  ·  12Comments  ·  Source: openjournals/joss-reviews

Submitting author: @vsoch (Vanessa Sochat)
Repository: https://www.github.com/expfactory/expfactory
Version: v3.0.0
Editor: @leeper
Reviewer: @oesteban
Archive: 10.5281/zenodo.1117203

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/91829e3895316bb54bf4a3b5e32cdb71"><img src="http://joss.theoj.org/papers/91829e3895316bb54bf4a3b5e32cdb71/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/91829e3895316bb54bf4a3b5e32cdb71/status.svg)](http://joss.theoj.org/papers/91829e3895316bb54bf4a3b5e32cdb71)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@oesteban, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @leeper know.

### Conflict of interest

Code of Conduct

General checks

  • [x] Repository: Is the source code for this software available at the repository url?
  • [x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • [x] Version: Does the release version given match the GitHub release (v3.0.0)?
  • [x] Authorship: Has the submitting author (@vsoch) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • [x] Installation: Does installation proceed as outlined in the documentation?
  • [x] Functionality: Have the functional claims of the software been confirmed?
  • [x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • [x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • [x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • [x] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • [x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • [x] Authors: Does the paper.md file include a list of authors with their affiliations?
  • [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
accepted published recommend-accept review

Most helpful comment

Yes, I do.

On Feb 4, 2018 08:35, "Thomas J. Leeper" notifications@github.com wrote:

@oesteban https://github.com/oesteban Can you confirm that you are
happy with the package in its current form?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/521#issuecomment-362920258,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAkhxqvnBbxdY-EVzVMJbs7KwZlBjhxLks5tRdxAgaJpZM4RLSRN
.

All 12 comments

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @oesteban it looks like you're currently assigned as the reviewer for this paper :tada:.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
Attempting PDF compilation. Reticulating splines etc...
https://github.com/openjournals/joss-papers/blob/joss.00521/joss.00521/10.21105.joss.00521.pdf

@whedon set 10.5281/zenodo.1117203 as archive

OK. 10.5281/zenodo.1117203 is the archive.

@oesteban Can you confirm that you are happy with the package in its current form?

Yes, I do.

On Feb 4, 2018 08:35, "Thomas J. Leeper" notifications@github.com wrote:

@oesteban https://github.com/oesteban Can you confirm that you are
happy with the package in its current form?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/521#issuecomment-362920258,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAkhxqvnBbxdY-EVzVMJbs7KwZlBjhxLks5tRdxAgaJpZM4RLSRN
.

Thank you, @oesteban!

@arfon This one's over to you.

@oesteban - many thanks for your review here and to @leeper for editing this submission ✨

@vsoch - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00521 ⚡️ 🚀 💥

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippet:

[![DOI](http://joss.theoj.org/papers/10.21105/joss.00521/status.svg)](https://doi.org/10.21105/joss.00521)

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider volunteering to review for us sometime in the future. You can add your name to the reviewer list here: http://joss.theoj.org/reviewer-signup.html

:avocado: :avocado: :avocado: woohooo!! thanks @whedon @oesteban @arfon and @leeper ! :avocado: :avocado: :avocado:

Was this page helpful?
0 / 5 - 0 ratings