Joss-reviews: [PRE REVIEW]: Minimalist And Customizable Optimization Package

Created on 10 Sep 2020  路  41Comments  路  Source: openjournals/joss-reviews

Submitting author: @jbuisine (J茅r么me BUISINE)
Repository: https://github.com/jbuisine/macop
Version: v1.0.0
Editor: @melissawm
Reviewers: @stsievert, @torressa
Managing EiC: Daniel S. Katz

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @jbuisine. Currently, there isn't an JOSS editor assigned to your paper.

@jbuisine if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
Python Shell TeX pre-review

All 41 comments

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

Failed to discover a Statement of need section in paper

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.36 s (424.2 files/s, 105956.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            59           7168             58          10148
JavaScript                      11           2200           2239           8326
SVG                              1              0              0           2671
Python                          31            635            793           1114
CSS                              4            164             34            642
reStructuredText                39            681            563            265
Markdown                         3            104              0            178
TeX                              1             10              0            124
YAML                             2             10              4             51
make                             1              5              6             11
Bourne Shell                     1              3              2              8
-------------------------------------------------------------------------------
SUM:                           153          10980           3699          23538
-------------------------------------------------------------------------------


Statistical information for the repository '2658' was gathered on 2020/09/10.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
J茅r么me BUISINE                  39         17309           2002          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
J茅r么me BUISINE            15307           88.4          1.1               17.99
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/0-306-48056-5_11 is OK
- 10.1109/TEVC.2007.892759 is OK
- 10.1016/j.cor.2006.02.008 is OK
- 10.1109/TEVC.2013.2239648 is OK
- 10.1007/s00158-004-0465-1 is OK
- 10.1109/ICMLA.2007.35 is OK
- 10.3390/rs10071117 is OK

MISSING DOIs

- None

INVALID DOIs

- None

馃憢 @jbuisine - thanks for your submission. The next step will be an internal discussion by JOSS editors about the scope, which will take about a week, then we will get back to you about the next steps

@whedon query scope

Submission flagged for editorial review.

@jbuisine upon initial inspection our board has decided this work may be in scope for JOSS. I will now proceed find an editor to handle this work. We do feel the paper needs a lot of improvement so please do work with the editor to get it improved, likely prior to the formal review stage.

@whedon invite @melissawm as editor

@melissawm has been invited to edit this submission.

@Kevin-Mattheus-Moerman Thank you for your answer, I am of course available for any modification of the document in order to improve it.

@whedon assign @melissawm as editor

OK, the editor is @melissawm

Hello, @jbuisine ! Before we proceed into the review stage, I'd like to suggest a careful review of JOSS's Submission Requirements. More specifically, I would suggest a stronger statement of need and a description of where this software fits into the current landscape, as it's not clear what differentiates it from existing optimization/OR frameworks. Also, if this was created to solve a particular research problem, I would encourage it to be cited somewhere in the paper. Please let me know if you have any questions or comments!

Hello @melissawm, thank you for your advice, I will take it into account and modify the document in order to situate the package in the bibliography!

@whedon generate pdf

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Hello @melissawm, thanks to your advices, I generated a new version of the submited paper. I detailed the purpose and the need of this developed package during my thesis.

Do not hesitate to tell me if something is not very clear or if something seems to be missing.

Thanks in advance.

@whedon generate pdf

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Hello, @jbuisine ! Thank you for the modifications. I noticed a number of typos, which I think might be corrected before the review stage - maybe going through an autocorrect feature. Another issue that I think might be worth noting is that the problem (or problems) being solved by the software are not explicitly mentioned in the software paper. From the context, I understand you are doing global optimization in an OR setting - is that correct? I think that is worth mentioning somewhere.

Finally: do you have any suggestions for potential reviewers from the list mentioned in the first comment on this issue? Thank you!

@whedon generate pdf

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Hello @melissawm,

Thank you again for your feedback. I have updated the paper accordingly, I hope this is more understandable.

That's right, the idea is to propose a generic tool allowing to refrain from some recurrent concepts when implementing operational search algorithms (solution evaluation, hierarchical management of algorithms, backups, algorithm reloading). As the tool is not specific, the user could implement his algorithm without having to overload or be limited when faced with the specificity of an implementation. It is a tool developed within the framework of the thesis which allowed me to implement some specific algorithms quickly and which I would like to share.

Concerning the suggestions of reviewers, I was thinking about : stsievert, jakobbossek and rowanc1 (I do not quote them directly here to avoid unwanted spam).

Thanks.

Thank you, @jbuisine, that is much clearer now. I'll proceed with the reviewer's invitations. If you have any further questions or comments, please let me know!

:wave: Hello @stsievert, @rowanc1 would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html Let me know if you need any more information. Thank you!

Hi @melissawm, I don't have time at this point, sorry.

@melissawm yes, I can review this.

Thanks, @stsievert ! I'll add you as a reviewer but won't start the review right away as we're still missing another reviewer.

@whedon assign @stsievert as reviewer

OK, @stsievert is now a reviewer

Hello @torressa, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html Let me know if you need any more information. Thank you!

Hey @melissawm, definitely keen, a bit swamped at the minute, so may be two/three weeks.
If that's alright, then go ahead :)

Thank you @torressa! If @jbuisine is ok with this timeframe, we can go ahead.

Hello, I agree, this is not a problem for me.

Great! Then I'll add the second reviewer and open the review issue. This issue here will be closed, and all further communication and work will be done on the REVIEW issue.

@whedon add @torressa as reviewer

OK, @torressa is now a reviewer

@whedon start review

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2812.

Was this page helpful?
0 / 5 - 0 ratings