Joss-reviews: [PRE REVIEW]: deepCR: Cosmic Ray Rejection with Deep Learning

Created on 14 Aug 2019  ·  35Comments  ·  Source: openjournals/joss-reviews

Submitting author: @kmzzhang (Keming Zhang)
Repository: https://github.com/profjsb/deepCR
Version: 0.1.5
Editor: @terrytangyuan
Reviewers: @shreyasbapat, @DanielLenz

Author instructions

Thanks for submitting your paper to JOSS @kmzzhang. Currently, there isn't an JOSS editor assigned to your paper.

@kmzzhang if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
AAS Python TeX pre-review

All 35 comments

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

Attempting PDF compilation. Reticulating splines etc...

PDF failed to compile for issue #1647 with the following error:

Could not find bibliography file: paper.bib
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@kmzzhang - There doesn't seem to be a paper.bib file in your repo

Hello,

I have just included paper.bib in the repo.

Thanks,
Keming

On Aug 13, 2019, at 6:54 PM, Daniel S. Katz <[email protected]notifications@github.com> wrote:

@kmzzhanghttps://github.com/kmzzhang - There doesn't seem to be a paper.bib file in your repo


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/1647?email_source=notifications&email_token=AJSWHVB2AIJ62IWWRBHFLVDQENQUXA5CNFSM4ILQH3J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4HO65A#issuecomment-521072500, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJSWHVFJQVIWQZGOTFTS2U3QENQUXANCNFSM4ILQH3JQ.

@whedon generate pdf

Attempting PDF compilation. Reticulating splines etc...

There's a misspelled robust near the end of the paper... Please fix it, and then add a new comment here containing @whedon generate pdf to rebuild the paper

👋 @terrytangyuan - would you be willing to review this submission?

@whedon assign @terrytangyuan as editor

OK, the editor is @terrytangyuan

Sure, @kmzzhang do you have a list of potentials reviewers in mind? If so, please mention them here.

@terrytangyuan, may I suggest nilesh-patil, DanielLenz, shreyasbapat as potential reviewers? They have listed both deep learning and astronomy as their expertise. Additionally, I don’t see the figure in the generated paper proof. Is the figure format wrong? Thanks.

I wonder if the path to the image is a problem? @arfon - can you help with this? (since we can't see the generate pdf log to see any error msgs)

Hi @nilesh-patil @DanielLenz @shreyasbapat Would you be interested in reviewing this submission?

Hi @nilesh-patil @DanielLenz @shreyasbapat Would you be interested in reviewing this submission?

Yes sure! I can :)

I'd be happy to review in general. However, the work has already been described and published in Zhang & Bloom (2019, submitted to AAS), and will undergo peer review there as well.

I wonder if the path to the image is a problem? @arfon - can you help with this? (since we can't see the generate pdf log to see any error msgs)

@kmzzhang - can you update the URL of the image to: https://raw.githubusercontent.com/profjsb/deepCR/master/imgs/postage-sm.jpg rather than using the relative path?

I'd be happy to review in general. However, the work has already been described and published in Zhang & Bloom (2019, submitted to AAS), and will undergo peer review there as well.

Also, can you confirm @kmzzhang that this is a joint submission with AAS?

@whedonhttps://github.com/whedon generate pdf

On Aug 14, 2019, at 5:24 PM, Arfon Smith <[email protected]notifications@github.com> wrote:

I wonder if the path to the image is a problem? @arfonhttps://github.com/arfon - can you help with this? (since we can't see the generate pdf log to see any error msgs)

@kmzzhanghttps://github.com/kmzzhang - can you update the URL of the image to: https://raw.githubusercontent.com/profjsb/deepCR/master/imgs/postage-sm.jpg rather than using the relative path?

I'd be happy to review in general. However, the work has already been described and published in Zhang & Bloom (2019, submitted to AAS), and will undergo peer review there as well.

Also, can you confirm @kmzzhanghttps://github.com/kmzzhang that this is a joint submission with AAS?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/1647?email_source=notifications&email_token=AJSWHVHJCWIN3GVRXCQ7O2DQESO4XA5CNFSM4ILQH3J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4KPM5A#issuecomment-521467508, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJSWHVHUCSAOWZRTWIQNIGTQESO4XANCNFSM4ILQH3JQ.

you probably need to do this on github - doing it by email doesn't quite work

Yes, this is a joint submission with AAS.

On Aug 14, 2019, at 5:24 PM, Arfon Smith <[email protected]notifications@github.com> wrote:

I wonder if the path to the image is a problem? @arfonhttps://github.com/arfon - can you help with this? (since we can't see the generate pdf log to see any error msgs)

@kmzzhanghttps://github.com/kmzzhang - can you update the URL of the image to: https://raw.githubusercontent.com/profjsb/deepCR/master/imgs/postage-sm.jpg rather than using the relative path?

I'd be happy to review in general. However, the work has already been described and published in Zhang & Bloom (2019, submitted to AAS), and will undergo peer review there as well.

Also, can you confirm @kmzzhanghttps://github.com/kmzzhang that this is a joint submission with AAS?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/1647?email_source=notifications&email_token=AJSWHVHJCWIN3GVRXCQ7O2DQESO4XA5CNFSM4ILQH3J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4KPM5A#issuecomment-521467508, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJSWHVHUCSAOWZRTWIQNIGTQESO4XANCNFSM4ILQH3JQ.

Yes, this is a joint submission with AAS.

👍 thanks for confirming.

/ cc @crawfordsm

@kmzzhang Please use Github instead of email for responding in the future since the responses from email is very verbose. Thank you.

@whedon assign @shreyasbapat as reviewer

OK, the reviewer is @shreyasbapat

@whedon add @DanielLenz as reviewer

OK, @DanielLenz is now a reviewer

@whedon start review

@whedon generate pdf

Attempting PDF compilation. Reticulating splines etc...

@whedon start review

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1651. Feel free to close this issue now!

@shreyasbapat @DanielLenz Thank you! Look forward to your review in #1651!

Was this page helpful?
0 / 5 - 0 ratings