Joss-reviews: [PRE REVIEW]: Ising_OPV v4.0: Experimental Tomography Data Import, Interpretation, and Analysis

Created on 10 Oct 2018  路  56Comments  路  Source: openjournals/joss-reviews

Submitting author: @MikeHeiber (Michael Heiber)
Repository: https://github.com/MikeHeiber/Ising_OPV
Version: v4.0.0-rc.2
Editor: @katyhuff
Reviewers: @myousefi2016, @stuartcampbell, @mdoucet

Author instructions

Thanks for submitting your paper to JOSS @MikeHeiber. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@MikeHeiber if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
Makefile Shell TeX pre-review

All 56 comments

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @labarba it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands
Attempting PDF compilation. Reticulating splines etc...

:wave: @labarba - the submitting author suggested you as the handling editor.

PDF failed to compile for issue #1011 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 15 0 15 0 0 167 0 --:--:-- --:--:-- --:--:-- 168
pandoc-citeproc: reference pfannmoeller2013ees not found
pandoc-citeproc: reference vanbavel2009nl not found
pandoc-citeproc: reference pfannmoeller2013ees not found
pandoc-citeproc: reference proudian2018arXiv not found
pandoc-citeproc: reference heiber2018ising4 not found
Error producing PDF.
! Missing $ inserted.

$
l.265 ...{Acknowledgments}\label{acknowledgments}}

Looks like we failed to compile the PDF

@whedon commands

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Compile the paper
@whedon generate pdf

馃毀 馃毀 馃毀 Experimental Whedon features 馃毀 馃毀 馃毀

# Compile the paper from a custom git branch
@whedon generate pdf from branch custom-branch-name

I would suggest @stuartcampbell as a potential reviewer that is knowledgeable about C++ and materials science.

@whedon generate pdf from branch joss-edits

Attempting PDF compilation from custom branch joss-edits. Reticulating splines etc...

PDF failed to compile for issue #1011 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 15 0 15 0 0 180 0 --:--:-- --:--:-- --:--:-- 180
Error producing PDF.
! Missing $ inserted.

$
l.266 ...{Acknowledgments}\label{acknowledgments}}

Looks like we failed to compile the PDF

@whedon generate pdf from branch joss-edits

Attempting PDF compilation from custom branch joss-edits. Reticulating splines etc...

PDF failed to compile for issue #1011 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 15 0 15 0 0 139 0 --:--:-- --:--:-- --:--:-- 140
Error producing PDF.
! Missing $ inserted.

$
l.279

Looks like we failed to compile the PDF

@whedon generate pdf from branch joss-edits

Attempting PDF compilation from custom branch joss-edits. Reticulating splines etc...

PDF failed to compile for issue #1011 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 15 0 15 0 0 90 0 --:--:-- --:--:-- --:--:-- 90
Error producing PDF.
! Missing $ inserted.

$
l.280

Looks like we failed to compile the PDF

@arfon @labarba Any idea why the PDF is not compiling? I am not using any math in the document, so I can't figure out why latex is complaining.

I think the issue is actually with the underscore in the title. This pull
request should fix the paper: https://github.com/MikeHeiber/Ising_OPV/pull/8

@arfon I tried that as well, and it didn't seem to fix the problem. See the joss-edits branch for my latest edited version.

@whedon commands

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

# Compile the paper
@whedon generate pdf

馃毀 馃毀 馃毀 Experimental Whedon features 馃毀 馃毀 馃毀

# Compile the paper from a custom git branch
@whedon generate pdf from branch custom-branch-name

@whedon generate pdf from branch joss-edits

Attempting PDF compilation from custom branch joss-edits. Reticulating splines etc...

PDF failed to compile for issue #1011 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 15 0 15 0 0 127 0 --:--:-- --:--:-- --:--:-- 127
Error producing PDF.
! Missing $ inserted.

$
l.280

Looks like we failed to compile the PDF

@MikeHeiber - I'm not sure what's going on here. I can compile your paper fine with the edits in your joss-edits branch: 10.21105.joss.01011.pdf

@arfon Hmm... Well thanks for providing the compiled PDF. Based on how that compiled, I've made a few more minor corrections/modifications to the joss-edits branch.

@whedon generate pdf from branch joss-edits

Attempting PDF compilation from custom branch joss-edits. Reticulating splines etc...

PDF failed to compile for issue #1011 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 15 0 15 0 0 189 0 --:--:-- --:--:-- --:--:-- 189
Error producing PDF.
! Missing $ inserted.

$
l.279

Looks like we failed to compile the PDF

Compiled again locally 10.21105.joss.01011.pdf

The proof looks good to me!

@labarba @arfon Just wondering when reviewer(s) will be assigned so that we can move forward. Please let me know if you are waiting on me for anything. Thanks!

You should expect at least a period of two weeks for finding reviewers. Sometimes more. Editors and reviewers are volunteers and most often have latency before new tasks enter our queue. Right now, for example, I'm starting a trip, with two talks to give, and last week, another trip and another talk.

@arfon @labarba It's now been 4 weeks since submission. I understand that sometime things are busy, but it should not take so long to start assigning reviewers. Is there possibly another editor available that has time to handle this submission?

:wave: @katyhuff - would you be willing to edit this for JOSS?

@arfon @labarba It's now been 4 weeks since submission. I understand that sometime things are busy, but it should not take so long to start assigning reviewers. Is there possibly another editor available that has time to handle this submission?

Hi @MikeHeiber - thanks for your patience here. I posit that your frustration here is a consequence of the extreme transparency of the JOSS review process. That is, if this were this a 'traditional' journal, the process of assignment of an editor would be complete opaque to you as the submitting author and as such a ~1 month delay would be very reasonable anywhere _other than_ JOSS.

Thanks for your patience 馃槂

@arfon Thank you for trying to move this along. With the traditional publishers that I submit to, most of the time is spent waiting for the reviewers to assess the technical aspects of the work and not on waiting for the editors to make initial editorial decisions and sending the manuscript out for review. I am happy to put in some more work to comb over the reviewer list again and suggest reviewers if it helps get things going. I could even suggest new JOSS reviewers that work in my field and are active Github users, if it would help.

@MikeHeiber This level of materials science is slightly beyond my wheelhouse, so I spent a few hours on the plane looking over your submission to understand the purpose. At this point, I think I grok it, and I'm certainly happy to help out in finding reviewers unless @labarba has an objection ( @labarba I know you're on travel and juggling more papers than most, but if you object to changing editors I'm happy to return this to your capable hands ).

@whedon assign @katyhuff as editor

OK, the editor is @katyhuff

Now, @MikeHeiber , let's ping a few fitting reviewers, with materials science, physics, and c or c++ expertise. We can start the review once two or three of them accept the request to review.


Dear reviewers,

  • @stuartcampbell as suggested: Stuart, are you able to and interested in taking on this review?
  • @mdoucet Mathieu, are you able to and interested in taking on this review?
  • @jochym : Pawel, are you able to and interested in taking on this review?
  • @trallard : Tania, are you able to and interested in taking on this review?
  • @myousefi2016 : Mehrdad, are you able to and interested in taking on this review?

Title: Ising_OPV v4.0: Experimental Tomography Data Import, Interpretation, and Analysis
Summary: A C++ software tool for generating and analyzing model bulk heterojunction morphologies in a parallel computing environment
Topic: Computational Materials Science
Article Proof: https://github.com/openjournals/joss-reviews/files/2474390/10.21105.joss.01011.pdf
Submitting author: @MikeHeiber (Michael Heiber)
Repository: https://github.com/MikeHeiber/Ising_OPV
Version: v4.0.0-rc.2

@katyhuff Hi, I鈥檓 interested to review this software.

@myousefi2016 Excellent! Thank you for the prompt response. We'll get started as soon as a couple of folks volunteer.

@katyhuff yes I'm happy to help

Fabulous, thanks @stuartcampbell ! I'll give the other reviewers another few hours to volunteer if they're interested before we start the review. Three is always slightly better than two if folks are interested!

@whedon assign @myousefi2016 as reviewer

OK, the reviewer is @myousefi2016

@whedon add @stuartcampbell as reviewer

OK, @stuartcampbell is now a reviewer

@katyhuff I鈥檓 happy to help

Thank you @mdoucet !

@whedon add @mdoucet as reviewer

OK, @mdoucet is now a reviewer

@whedon start review

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1072. Feel free to close this issue now!

Hi Folks, We'll conduct the review over in #1072 !

Was this page helpful?
0 / 5 - 0 ratings