Joss-reviews: [PRE REVIEW]: Opycleid: A Python package for transformational music theory

Created on 16 Sep 2018  ยท  35Comments  ยท  Source: openjournals/joss-reviews

Submitting author: @AlexPof (Alexandre Popoff)
Repository: https://github.com/AlexPof/opycleid
Version: 0.2.5
Editor: @danielskatz
Reviewers: @drvinceknight, @adammichaelwood

Author instructions

Thanks for submitting your paper to JOSS @AlexPof. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@AlexPof if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
Python TeX pre-review

All 35 comments

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @danielskatz it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands
Attempting PDF compilation. Reticulating splines etc...

PDF failed to compile for issue #956 with the following error:

/app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-2caaf5cba519/lib/whedon.rb:116:in parse_affiliations': undefined methodeach' for nil:NilClass (NoMethodError)
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-2caaf5cba519/lib/whedon.rb:103:in parse_authors' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-2caaf5cba519/lib/whedon.rb:73:ininitialize'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-2caaf5cba519/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-2caaf5cba519/lib/whedon/processor.rb:32:inset_paper'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-2caaf5cba519/bin/whedon:37:in prepare' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:inrun'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:indispatch'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-2caaf5cba519/bin/whedon:99:in from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in load' from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in

'

:wave: @danielskatz - the submitting author suggested you as the handling editor.

@whedon commands

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Compile the paper
@whedon generate pdf

๐Ÿšง ๐Ÿšง ๐Ÿšง Experimental Whedon features ๐Ÿšง ๐Ÿšง ๐Ÿšง

# Compile the paper from a custom git branch
@whedon generate pdf from branch custom-branch-name

@whedon generate pdf

Attempting PDF compilation. Reticulating splines etc...

I'm fixing some bugs in the paper.md and paper.bib files.

@whedon generate pdf

Attempting PDF compilation. Reticulating splines etc...

I'm glad to have my musical abilities and affinities recognized, and I will attempt to handle this as the editor.

@AlexPof - can you suggest some possible reviewers from this list of people who have already agreed to review for JOSS and may be suitable for this submission?

@danielskatz - Thank you for accepting to be the editor for this submission. I'm afraid I'm not familiar enough with the reviewers which are mentionned in the list to make a proper choice. May I perhaps suggest drvinceknight who seems to be familiar with sagemath and Python, and who might be interested in the algebraic and computational aspects ?

@drvinceknight - would you be willing to be one of the reviewers for this submission?

Yup no problem at all :+1:

(We're expecting an increment to our little family over next couple of days/weeks so my review could be slightly delayed.)

Thanks @drvinceknight - I'm also working on finding another reviewer by email, so this likely won't start immediately.

@whedon assign @drvinceknight as reviewer

OK, the reviewer is @drvinceknight

@danielskatz To anticipate the review process, I have two questions:

  • I am not affiliated to any university / lab / etc. I work for a private company, and this package is completely unrelated. Can this be a problem for the submission process ?
  • This package is hosted on PyPi and can be installed via pip, with version number 0.2.5. If the review process highlights some changes to be made, does this mean that the version number will have to be changed and the package updated on PyPi ?
    Thank you in advance for your help.

I am not affiliated to any university / lab / etc. I work for a private company, and this package is completely unrelated. Can this be a problem for the submission process ?

no, this is fine.

This package is hosted on PyPi and can be installed via pip, with version number 0.2.5. If the review process highlights some changes to be made, does this mean that the version number will have to be changed and the package updated on PyPi ?

yes, that's likely.

@willingc - would you be interested in reviewing this? (mostly putting this here as a recording mechanism, since we will talk in person tomorrow)

๐Ÿ‘‹ @willingc - you mentioned a couple of other people on Monday - Can we ping them here and see if they would be able and willing to review this?

I am happy to be a reviewer on this as well. I have a music degree and am a python developer and tech writer.

@adammichaelwood - thanks for agreeing to do this

@whedon add @adammichaelwood as reviewer

OK, @adammichaelwood is now a reviewer

@whedon start review

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/981. Feel free to close this issue now!

๐Ÿ‘‹ @willingc - you mentioned a couple of other people on Monday - Can we ping them here and see if they would be able and willing to review this?

It looks like there are now enough reviewers. In the future, would @mscuthbert or @jefftrevino be willing to consider being a reviewer for music submissions for the Journal of Open Source Software (JOSS)?

๐Ÿ‘‹ @mscuthbert or @jefftrevino - if you are interested in reviewing in the future, please volunteer via http://joss.theoj.org/reviewer-signup.html

@willingc Thanks for thinking of me, but I don't know anything about transformational music theory. I use Python to compose by aggregating instances of notational element classes (as in the Abjad API for Formalized Score Control), but I don't model these kinds of relationships abstractly in my work, except implicitly through generative processes. (Although perhaps I should....)

@jefftrevino I think that @willingc is asking if weโ€™d be willing to review open source projects in music in general and not this particular one. To which I say, โ€œof course!โ€

Was this page helpful?
0 / 5 - 0 ratings