Joss-reviews: [PRE REVIEW]: countrycode: An R package to convert country names and country codes

[whedon]

Submitting author: @vincentarelbundock (Vincent Arel-Bundock)
Repository: https://github.com/vincentarelbundock/countrycode
Version: 1.00.0
Editor: @leeper
Reviewers: @andybega

Author instructions

Thanks for submitting your paper to JOSS @vincentarelbundock. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@vincentarelbundock if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @leeper it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

Failed to discover a valid open source license.

[whedon]

PDF failed to compile for issue #838 with the following error:

/app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/lib/whedon.rb:83:in check_fields': Paper YAML header is missing expected fields: affiliations (RuntimeError) from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/lib/whedon.rb:69:ininitialize'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/lib/whedon/processor.rb:32:inset_paper'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/bin/whedon:37:in prepare' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:inrun'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:indispatch'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/bin/whedon:99:in from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in load' from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in

'

[vincentarelbundock]

Thanks a lot for working on this. I really appreciate the time an efforts you invest in JOSS!

I added a LICENSE.txt file to the repo.

Also, I suspect that the PDF compilation failed because I had added this to the markdown header CJKmainfont: STSong (chinese characters didn't render locally on my computer without that line). I have now removed that line. Hopefully this fixes the failed to compile

[arfon]

@vincentarelbundock - actually, it looks like you're missing the affiliations block in your paper.md file. Please take a look at this example: https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography

[arfon]

:wave: @leeper - the submitting author suggested you as the handling editor.

[vincentarelbundock]

thanks! not sure how I could have missed this. The header in the new version mimics the example you linked to.

[arfon]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

--> Check article proof :page_facing_up: <--

[NilsEnevoldsen]

@vincentarelbundock Looks like you need to add back CJKmainfont if it doesn't break anything.

[vincentarelbundock]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

--> Check article proof :page_facing_up: <--

[vincentarelbundock]

@NilsEnevoldsen I just tried, but the chinese characters don't show up, even with CJKmainfont. If there's no way to render these characters, we can find another usage example to replace that one.

[leeper]

@whedon assign @andybega as reviewer

[whedon]

OK, the reviewer is @andybega

[leeper]

@whedon start review

[whedon]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/848. Feel free to close this issue now!