Jormungandr: Should v0.7.0-rc4 have these build warnings?
When building the v0.7.0-rc4 release, I noticed the following warnings. Are these expected?
Built on Ubuntu 18.04 with rustc 1.38.0 (625451e37 2019-09-23)
############ STD Out Log
``
warning: use of deprecated item 'blockchain::storage::Storage::get_inner': use the stream iterator instead
--> jormungandr/src/client.rs:106:27
|
106 | let storage = storage.get_inner().wait().unwrap();
| ^^^^^^^^^
|
= note:#[warn(deprecated)]` on by default
warning: use of deprecated item 'blockchain::storage::Storage::get_inner': use the stream iterator instead
--> jormungandr/src/client.rs:133:27
|
133 | let storage = storage.get_inner().wait().unwrap();
| ^^^^^^^^^
warning: use of deprecated item 'blockchain::storage::Storage::get_inner': use the stream iterator instead
--> jormungandr/src/client.rs:195:27
|
195 | let storage = storage.get_inner().wait().unwrap();
| ^^^^^^^^^
warning: unused variable: block_cache_ttl
--> jormungandr/src/main.rs:183:13
|
183 | let block_cache_ttl: Duration = Duration::from_secs(3600);
| ^^^^^^^^^^^^^^^ help: consider prefixing with an underscore: _block_cache_ttl
|
= note: #[warn(unused_variables)] on by default
warning: unused variable: e
--> jormungandr/src/blockchain/process.rs:445:19
|
445 | .map_err(|e| {
| ^ help: consider prefixing with an underscore: _e
warning: unused variable: parent_ref
--> jormungandr/src/blockchain/process.rs:466:65
|
466 | PreCheckedHeader::HeaderWithCache { header, parent_ref } => {
| ^^^^^^^^^^ help: try ignoring the field: parent_ref: _
warning: unused variable: logger
--> jormungandr/src/blockchain/process.rs:439:5
|
439 | logger: Logger,
| ^^^^^^ help: consider prefixing with an underscore: _logger
warning: function is never used: process_chain_headers_into_block_request
--> jormungandr/src/blockchain/process.rs:436:1
|
436 | / pub fn process_chain_headers_into_block_request(
437 | | mut blockchain: Blockchain,
438 | | headers: S,
439 | | logger: Logger,
... |
476 | | .collect()
477 | | }
| |_^
|
= note: #[warn(dead_code)] on by default
warning: method is never used: stats
--> jormungandr/src/network/p2p/comm/peer_map.rs:145:5
|
145 | pub fn stats(&mut self) -> &mut PeerStats {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Finished release [optimized] target(s) in 5m 59s
Installing /home/cardano/.cargo/bin/jormungandr
Linicks
All 3 comments
These are mostly harmless :laughing: reminding us to implement something that was stubbed out, or do cleanup.
mzabaluev
on 2 Nov 2019
I'm not sure if a recent crash (Nov 02 16:40:15.699 ) was associated with this, but the log did provide a not yet implemented warning just before the crash. I didn't have BACKTRACE set so I can't provide one :) I just wanted to share that tidbit. Interestingly, after deleting the storage directory and restarting the node, it stabilized again.
```
thread 'block0' panicked at 'not yet implemented: method to load a Ref from the storage is not yet there', jormungandr/src/blockchain/chain.rs:259:37
Linicks
on 2 Nov 2019
@Linicks not related to this issue. Also, you might wanna use support channel to report issues (to avoid creating duplicates), or feel free to hop by workgroup on telegram instead
rdlrt
on 2 Nov 2019
Related issues
NicolasDP
路
19Comments
tstdin
路
28Comments
Linicks
路
13Comments
disassembler
路
14Comments
hemants1
路
14Comments
Most helpful comment
@Linicks not related to this issue. Also, you might wanna use support channel to report issues (to avoid creating duplicates), or feel free to hop by workgroup on telegram instead