Joplin: "move to notebook" list not sorted in alphabetic order

[foxmask]

Environment

Joplin version: 1.0.200
Platform: linux
OS specifics: debian

Steps to reproduce

1. when moving note to another notebook the popup list is not sorted in alpha order

[coderrsid]

Hey @foxmask, thanks for reporting. I just checked again for the error you specified, but i don't see any. You can see in the below GIF it is rendering properly according to the notebooks listed in sidebar.

Can you provide any screenshot or GIF for the problem you're facing? 😄

[foxmask]

@coderrsid you can see a screencast I made here https://github.com/laurent22/joplin/issues/3053 when I move note ; you can see "Tech" before "Projet" before "Maison" it looks like sorted in the other side.

[coderrsid]

Thanks for telling but that link is expired and can i ask why we have two different issues for a similar problem?

[foxmask]

because it's 2 issues ...

[coderrsid]

Although i see there is a sorting issue in here. I'll just fix this ASAP.

[foxmask]

https://send.firefox.com/download/33e37cab4250e811/#A1PBqx5T9u5cgRh9EUgWyg

[coderrsid]

Great. Now i can see the issue. Thanks for reporting. 😄

[tessus]

@coderrsid btw, the cursor looks really weird in the dialog:

Maybe, because it doesn't blink. It only starts blinking when you pick a folder.

[coderrsid]

Thanks @tessus . I'll look into this too.

[coderrsid]

@foxmask Can you add the GIF here too please. Unfortunately, the last one is removed again. 😄

[coderrsid]

And one more thing i want to ask is that the order of notebooks shown in your sidebar is perfectly right, the way it should be?

[foxmask]

yes the order in the left sidebar is the right one.

here is the gif

[coderrsid]

Thanks! I'll see what i can do.

[coderrsid]

@laurent22 Will it be right if i change the way how Folder.allAsTree( ) returns the folders tree in a sorted way instead of just rendering parent and children together but also sort them or instead i should just make them sort for the moveToNotebook . I believe it will be helpful in future use cases.

[coderrsid]

@tessus In my case, the cursor is working as expected. Although if it is an issue, it should be in all the dialog boxes using inputType: 'dropdown' . Can you check the cursor in the dialog box of Create note from Template or Create to-do from template or Insert Template

[tessus]

Will it be right if i change the way how Folder.allAsTree( ) returns the folders tree in a sorted way

How is this done by the web clipper? I believe the function returns a sorted result set. Either way, something like a boolean argument with a default is a good option (sort = true). On the other hand, why would someone ever want a not sorted result?
But maybe people would like the same order they set in Sort notebooks by. This is certainly an architectural question and this is something only Laurent can answer.
If it were me, I'd create a function that takes the sort order as argument, which is called with the order that is set in the menu. IMO that would be the most logical and consistent approach.

Can you check the cursor in the dialog box of Create note from Template or Create to-do from template or Insert Template

In those cases the cursor blinks right away. Not so with the Move to notebook dialog.

[coderrsid]

How is this done by the web clipper? I believe the function returns a sorted result set. Either way, something like a boolean argument with a default is a good option (sort = true). On the other hand, why would someone ever want a not sorted result?

That's why i asked laurent if i can change it to always return a sorted array by title. 😄

But maybe people would like the same order they set in Sort notebooks by. This is certainly an architectural question and this is something only Laurent can answer.

Yeah that would be something he can answer for sure.

If it were me, I'd create a function that takes the sort order as argument, which is called with the order that is set in the menu. IMO that would be the most logical and consistent approach.

that's a great idea, we can add a function which returns the order of the notebooks in the same option set in Sort notebooks by

In those cases the cursor blinks right away. Not so with the Move to notebook dialog.

Although it shouldn't have any problem as the dialog is a part of a simple dropdown which is similarly used in the other components i ask you to test in .. 😅 Still i'll just look at it again but do tell me how to reproduce the issue. Than k you so much for suggesting tessus. 😄

[coderrsid]

Will it be right if i change the way how Folder.allAsTree( ) returns the folders tree in a sorted way instead of just rendering parent and children together but also sort them or instead i should just make them sort for the moveToNotebook . I believe it will be helpful in future use cases.

@PackElend @bedwardly-down
what do you think about this?

[bedwardly-down]

This is honestly less us and more the dev team. Tessus and Laurent didn’t respond to that post directly, so I’d take that as them probably being indifferent to it. With everything going on, it might be better to take a step back here also and just patiently wait for more feedback or ask on the forums.

[coderrsid]

Sure. As you say sir.

[tessus]

@coderrsid

but do tell me how to reproduce the issue.

Not really much to it. right-click a note and click Move to notebook. The cursor does not blink.