Joplin: Right-click to assign a note to a notebook

[dbogdanov]

Add a new option to assign a notebook for a note or multiple notes with a right-click.

Currently, the right-click leads to a popup menu which already contains "Add or remove tags". New option "Move to a notebook" would be very useful.

Like "Add or remove tags", it would open a dialog where the user can select the notebook from a dropdown list with typeahed.

The problem with a current way to assign a notebook is that it can be only done by drag-n-drop. This is undesirable in some cases, such as when having too many notebooks as it becomes very tiring to scroll through the list of notebooks and then drag-n-drop the notes.

Environment

Joplin version: 1.0.175
Platform: MacOS, Linux, Windows

[tessus]

Not a bad idea. Please open a topic on the forum to discuss the feature.

[dbogdanov]

Done: https://discourse.joplinapp.org/t/right-click-to-assign-a-note-to-a-notebook/5183

[tessus]

@dbogdanov the feature request was accepted. Now we only have to find someone to implement it...

[CaptainNick]

@laurent22 I would like to work on this issue.

[laurent22]

That's great @CaptainNick! I've assigned the issue to you and if you need some help let us know.

[tessus]

@CaptainNick please make sure that you also include a live search field in the popup, otherwise it will be very hard to scroll through a myriad of folders. Imagine 100-200 nested folders. Scrolling would be a mess and time consuming matter.

[laurent22]

@tessus, it's already in the spec

dropdown list with typeahed

[tessus]

@laurent22 ahh, the last time I read the first comment that part was not there. This suggestion came only later in the forum.

[coderrsid]

Hey @laurent22. I would like to fix this issue. Is @CaptainNick is working on it?

[laurent22]

@CaptainNick, are you still working on it, or can I assign it to @coderrsid?

[CaptainNick]

@laurent22 yes I'm working on this. I'm getting hold of the codebase. Can you please allow 2 more days?

[laurent22]

@CaptainNick, sure we can wait, no problem.

[CaptainNick]

@laurent22 Looks like I might need more time. Kindly assign this issue to @coderrsid . I'll take up different issue later. Thank you. :)

[laurent22]

Ok thanks for letting me know. @coderrsid, feel free to go ahead and work on it then.

[coderrsid]

Sure, @laurent22

[tessus]

@coderrsid any update? It would be nice to keep us apprised.

[coderrsid]

Hey @tessus Sorry i couldn't reply although i am working on this issue instead https://github.com/laurent22/joplin/issues/2467

[coderrsid]

Hey @tessus I was just trying to fix this issue. I have one issue why there is two App.js, one in ElectronClient/App and other in app/dist/mac/.../Resources/app/app.js. Do i have to make changes to them both as they look same as my changes is not shown in the app.

[tessus]

Actually, there is no app directory anymore. If you pull the latest git master, you will see that.

If you are working on a local branch, create a new branch from your branch and do a git rebase master.
The file app.js is now in the directory ElectronClient.
The dist directory will be created when you create a release, so for testing this is not even necessary. Just do a npm start run in the ElectronClient directory.

[tessus]

The BUILD.md has been updated to reflect the changes to the build process.

[coderrsid]

Yeah i just saw that. Thanks @tessus

[coderrsid]

Hey @tessus I've updated my forked master branch but when i run it now with npm start run. It shows white screen in the app.

[tessus]

You probably didn't run npm i in the root directory of the project. (one up from ElectronClient)

[coderrsid]

I did.

[tessus]

No, you did it in the ElectronClient. Do a cd .. and run npm i.

[coderrsid]

Ohh thanks. Now it's working. Now i have a query related to issue.
As only drag and drop is the only option to move notes to diff. notebooks. Here in Sidebar.js which of these three functions defines the instance of when i drag and drop a folder or note on another folder?

[tessus]

I'm not sure. I think it's the Drop function. I haven't really worked with this part of the code.

But @laurent22 can tell you for sure. There should be a moveNote function or something. You don't need the drag and drop functions.

[coderrsid]

No i just need to see how drag and drop is assigning the folder to the note so when i make a prompt to select the folder i can do the same. Thanks for calling @laurent22

[tessus]

await Note.moveToFolder(noteId, folderId);

[coderrsid]

Thanks @tessus for the information. Although you can assign me this, i am already working on this.