Jkube: ConfigKey.java: Make DEFAULT_PREFIX private and final

Created on 28 Jun 2021  路  6Comments  路  Source: eclipse/jkube

Description

The following statement is reported as a vulnerability by SonarCloud:

https://github.com/eclipse/jkube/blob/bf88230a5c110d686ea02ffb45dba8a294f5e2e9/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/config/handler/property/ConfigKey.java#L153

should be changed to:

    private static final String DEFAULT_PREFIX = "docker";

Bonus

Create a unit test to verify your changes (intermediate).

How to _manually_ test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

first-timers-only good first issue

Most helpful comment

Hi, Can I please work on this? I'm a first time contributor.

All 6 comments

I see no one assign for this issue yet. can I work on this?

@Jayita10 : This issue is for first time contributors. Would you like to pick up some other slightly involved issue?

Hi @Jayita10
first-timers-only issues are intended for newcomers.
Our intention is to provide also additional (more involved and complex) help-wanted issues so that people who have already contributed to the project (just like you), can keep involved and helping out.

@Jayita10 : This issue is for first time contributors. Would you like to pick up some other slightly involved issue?

Yeah sure :)

Hi, Can I please work on this? I'm a first time contributor.

I have created a pull request with the changes.

Was this page helpful?
0 / 5 - 0 ratings