Jkube: EnvUtilTest.java: Replace hamcrest with AssertJ

Created on 22 Jul 2021  路  4Comments  路  Source: eclipse/jkube

Description

We are replacing the usage of Hamcrest assertions with AssertJ all over the project.

In EnvUtilTest.java, replace any usage of Hamcrest with the AssertJ (org.assertj.core.api.Assertions.assertThat).

e.g.
https://github.com/eclipse/jkube/blob/813074705147f9423dd807385c0d40e4670ddf9a/jkube-kit/common/src/test/java/org/eclipse/jkube/kit/common/util/EnvUtilTest.java#L401

should be changed to:

        assertThat(timestamp).isEqualTo(new Date(1445385600000L));

Bonus

Replace the rest of assertions (org.junit.Assert.*) with AssertJ too.

good first issue help wanted

Most helpful comment

Hey, shall I pick it up if you didn't started ? @himanshu007-creator

Sure!, @manusa please assign @ramananrpn this issue. 馃煩

All 4 comments

Hi, i would like to work on this issue

Hey, shall I pick it up if you didn't started ? @himanshu007-creator

Hey, shall I pick it up if you didn't started ? @himanshu007-creator

Sure!, @manusa please assign @ramananrpn this issue. 馃煩

@manusa @rohanKanojia Could you guys please review and merge this PR #789 ?

Was this page helpful?
0 / 5 - 0 ratings