Jitsi-meet: Please implent option for disable "invite more" and "not secure icon" in interface_config.js

Created on 20 May 2020  路  12Comments  路  Source: jitsi/jitsi-meet

Thank you for all your development.

After a long customizing of the interface for our users, now - after updating the unstable
flow, there are 2 more information panels / icons on the meet html web-interface.

It would be great to give those two panels a disable option inside the interface_config.js,
because in our use-case, both are more irrititating our users.

grafik

1 = panel for "alone"
2 = icon for "insecure channelname"

Thanx very much.

config feature-request uux

Most helpful comment

Folks, please chill.

Yes, we made a mistake by not having this off by default nor configurable.

On master it鈥檚 already off by default (though we鈥檒l likely review it and keep it enabled on meet.jit.si) and there is a config option. The option needs a bit of polish though, hopefully that gets done this week.

@RareAdventistBookProject The same way bad decisions drive people away from a project, self-entitled users drive voluntary contributors like @luixxiul away. Please consider that even if things may look a certain way, nothing here is arbitrary. Alienating project members is likely not going to get you what you need.

All 12 comments

ref: #6654

may someone is struggling in the same problem, a un-guaranted but simple workaround to
step back on the release without both web-frontend features:

apt-get install jitsi-meet-web=1.0.4119-1

This is an urgent problem: the "insecure channel" icon has to be removable in fully controlled or automated environments, where the user is unable to control room names.

See comments on: https://github.com/jitsi/jitsi-meet/pull/6754

The quick fix, is to hide it with css.

/usr/share/jitsi-meet/css/all.css

look for
.large-video-labels .circular-label.insecure{background:#d77976}

Replace with:
.large-video-labels .circular-label.insecure{display:none!important;background:#d77976}

or, as root:

cd /usr/share/jitsi-meet/
cp all.css all.css.dist
sed -i 's/.large-video-labels .circular-label.insecure{background:#d77976}/.large-video-labels .circular-label.insecure{display:none!important;background:#d77976}/g' all.css

If you need a quick fix, hiding with CSS as you mentioned seems to me the easiest and fastest way available right now.

In my humble opinion, until https://github.com/jitsi/jitsi-meet/issues/5653 will be addressed the insecure icon makes sense at https://meet.jit.si since there actually may unwanted participants join your conference if you pick up a common room name and that PR was intended to fix the urgent issue no matter how hasty it seems from the outside of the development team.

Still, I feel quite sad and sorry for the developer when I see someone calls something on GitHub projects a "disaster" or "urgent problem" if they can be fixable on your side...

consider these should always be matters of what is right, not who is right. If you're going to have configuration options that make sense for the demo site, you might consider prefixing them with some Hungarian notation, and not consider the community only secondarily, and a large base of installed systems as a red-headed step-child.

It would be worth noting that there have been already volunteers around the project as well like me, who have experienced an issue and felt that the community was treated just secondly (as you would see clearly on https://github.com/jitsi/jitsi-meet/issues/6164#issue-602399107) and then are trying to help the project. ie. members at @jitsi/bug-marshalls etc. instead of complaining.

If you stick with the fact that what the right thing is, there is honestly nothing I could do but say "sorry for your loss" and recommend you to push a PR as that is how open source projects are expected to work. Complaining will not fix the issue, as a matter of fact.

this is only seeking for your success.

Actually it will not belong to success of mine at all, as I'm just one of volunteers with some rights (to add labels to issues, close duplicates etc). I don't get paid, no team members except @saghul do neither recognize nor thank me explicitly. I have left comments even though I did not have to do so. Just out of my cause.

Folks, please chill.

Yes, we made a mistake by not having this off by default nor configurable.

On master it鈥檚 already off by default (though we鈥檒l likely review it and keep it enabled on meet.jit.si) and there is a config option. The option needs a bit of polish though, hopefully that gets done this week.

@RareAdventistBookProject The same way bad decisions drive people away from a project, self-entitled users drive voluntary contributors like @luixxiul away. Please consider that even if things may look a certain way, nothing here is arbitrary. Alienating project members is likely not going to get you what you need.

Thank you saghul. Some people may be overly aggressive or just mis-speak and sound that way, but the huge majority of users are completely thrilled with what all the developers are doing and truly appreciate all you do and how responsive you are to our requests and comments. Jitsi is great and getting greater.

Nice wording! I was about to submit something similar, glad this is moving forward. Thank you!

Thank you for your work, I'm just testing this new functionality, I'm testing this from the API IFrame and can't find the attribute to disable the "You are the only one in the meeting message". Can it be hidden from the interfaceConfigOverwrite or configOverwrite? Thanks for your help.

@saghul I have made a PR to create an additional interfaceConfig called SHOW_INVITE_MORE_HEADER, so we can disable it using interfaceConfigOverwrite
https://github.com/jitsi/jitsi-meet/pull/7021

Was this page helpful?
0 / 5 - 0 ratings