Jetpack: (5P) Podcast Player: Themes' incompatibilities

Created on 17 Apr 2020  路  3Comments  路  Source: Automattic/jetpack

Tested Podcast Player with a few themes and listed visual conflicts I noticed in each of them. I think we can treat this issue as a master thread to report all the theme styling issues that need to be taken care of.

TwentyEleven

Screenshot 2020-04-17 12 21 49

  • Podcast title doesn't inherit secondary color
  • The cover image is squashed

TwentyTwelve

Screenshot 2020-04-17 12 28 55

  • Visited link has different color
  • Cover image has border-radius

TwentyThirteen

Screenshot 2020-04-17 12 09 28

TwentyFourteen

Screenshot 2020-04-17 12 32 56

TwentyFifteen

Screenshot 2020-04-17 12 36 03

  • Borders everywhere! :D

TwentySixteen

Screenshot 2020-04-17 12 37 32

  • As in TwentyFifteen - extra borders

TwentySeventeen

Screenshot 2020-04-17 12 39 58

  • Borders!
  • Header title has top margin & different font-weight
  • Podcast title color is not inherited from secondary

TwentyNineteen

  • Lookin' good!

TwentyTwenty

  • Lookin' good!

Varia

  • Lookin' good!

Maywood

image

  • Hovered link color is always black (front-end only)
[Block] Podcast Player [Type] Bug

Most helpful comment

Nice job! Yes, let's not invest more time in those mejs styles.

All 3 comments

Let's remove those li borders & link styles globally and _lightly_ explore what a CSS reset for the block might look like and which consequences that would entail

https://github.com/Automattic/jetpack/pull/15504 fixes almost all of the issues with very minor CSS overrides overall.

The only issues it doesn't fix is the twenty fourteen and twenty thirteen media players. They both (but especially twenty fourteen) include CSS specific to the media elements player. We could increase the specificity and add a few more things to address twenty thirteen, but twenty fourteen would include many changes _only relevant to twenty fourteen_.

In my opinion, as both themes are 6 - 7 years old and would require so many specific changes just for them, that it's not worth addressing.

Nice job! Yes, let's not invest more time in those mejs styles.

Was this page helpful?
0 / 5 - 0 ratings