Jetpack: In-place connection: Try again button is not well aligned

Created on 3 Apr 2020  ·  9Comments  ·  Source: Automattic/jetpack

Steps to reproduce the issue

  1. It's a bit tricky since you'll need to force a connection to fail
  2. Try to connect via in-place connection
  3. See that "Try again" button is not well aligned

What I expected

not sure, actually. Should "Try again" replace the "Approve" button?

What happened instead

buttons_alignment

Connect Flow [Pri] High [Status] Needs Design Review [Type] Bug

Most helpful comment

I wonder if we have plans on reviewing these error responses as part of our connection focus?

As you can see from the first screenshot, the current error messages aren't very actionable. We do have plans to work on providing better connection error messages.

All 9 comments

Labeled it as High priority, since similar connection errors might happen quite often, and since it will create not a great first impression, I think we should prioritize fixing it.

This should be fixed once D47074-code is merged

it would look like this:

Jetpack ‹ Weekly Snakes — WordPress 2020-07-28 17-44-46

@Automattic/jetpack-design may I bother you with the sanity check for the above styling update?

The above seems a good fix for me. 👍

Maybe: can we be more explicit on what went wrong? Any chance without being overly technical?

These errors coming from WPCOM's /jetpack-blogs/$clientId/authorize response, so indeed we can iterate on them. Although it might not be a simple change. I'd prefer to leave this fix to remain style-related.

I wonder if we have plans on reviewing these error responses as part of our connection focus? (not sure who to ping about the above question, so cc @kbrown9 @leogermani)

Yes, makes sense to just fix the visual first. I was asking as the first screen was showing something different — let's go ahead. :)

Ah! In a second screenshot I was "simulating" connection error by going offline. Normally there should be meaningful error as in issue description

Deployed via r211170-wpcom

I wonder if we have plans on reviewing these error responses as part of our connection focus?

As you can see from the first screenshot, the current error messages aren't very actionable. We do have plans to work on providing better connection error messages.

Was this page helpful?
0 / 5 - 0 ratings