Jetpack: Assets CDN: jQuery not enqueing with MailPoet

[kraftbj]

Steps to reproduce the issue

1. Running stable WP and stable Jetpack, activate the Asset CDN
2. Install MailPoet (wordpress.org/plugins/mailpoet)
3. Visit the MailPoet page within wp-admin

What I expected

Plugin UI to load

What happened instead

jQuery errors and not seeing jQuery in the source.

ReferenceError: jQuery is not defined[Learn More] mailpoet.eaab3da3.js:4913:1
TypeError: MailPoet.I18n is undefined, can't access property "add" of it[Learn More] admin.php:339:1
TypeError: MailPoet.I18n is undefined, can't access property "add" of it[Learn More] admin.php:342:1
TypeError: $.fn is undefined, can't access property "select2" of it[Learn More] admin_vendor.eaab3da3.js:35395:3
TypeError: _mailpoet2.default.I18n is undefined, can't access property "t" of it[Learn More]

I don't quite understand what is going wrong yet, but seems like no JS files are being included in the source. Only CSS.

Without the Asset CDN, jQuery, etc is included via load-scripts.php. On other pages with Assets CDN enabled, I see jQuery via the CDN.

cc: @georgestephanis @zinigor @kriskarkoski @richardmtl

[cecoates]

Replicated this with two more users, 7140357-hc and 1459698-zen

[codemonkey-jack]

@kraftbj Jack from MailPoet here, we're releasing a patch for this on our side Tuesday.

The issue arises from the way we exclude 3rd party assets from loading on MailPoet admin pages to prevent breaking the newsletter editor and renderer.

Because of this, we have a list of paths that we allow assets to load from which are as follows;

// WP default
      '^/wp-admin',
      '^/wp-includes',
      'googleapis.com/ajax/libs',
      // third-party
      'query-monitor',
      'wpt-tx-updater-network'

Anything from a path outside of that will be blocked. We're patching in the Jetpack CDN and will be looking at other CDNs for a future release.

[kraftbj]

@codemonkey-jack Thanks for explanation! I had this on my list to dig into today and appreciate you stopping by. If there's anything you need from us, please let me know. I'll close this issue for now, deferring to y'all.

[carolynrosner]

11/26/18 - was a patch ever pushed? I have updated the plugin but it still does not work on my WP.com instance. Have contacted MailPoet support ... hate to keep bugging you but I'm getting bugged by others about why this still doesn't work - maybe I'm doing something wrong.

Thanks for any enlightenment!

WP support says they are currently seeing this PHP error related to the MailPoet Premium plugin:

http_host: onehealthonefuture.org request: POST /wp-admin/admin-ajax.php HTTP/1.1 type: php-errors tags: php_message: rename_old: old=/wp-content/plugins/mailpoet-premium/, new=/tmp/.plugin-1543256545472 referrer: https://onehealthonefuture.org/wp-admin/plugins.php

[jeherve]

@carolynrosner MailPoet was updated about a month ago to fix this issue, and another update was pushed by MailPoet about a week later to address further issues (see this comment). No fix was made in Jetpack itself, as the issues were all fixed within MailPoet.

WP support says they are currently seeing this PHP error related to the MailPoet Premium plugin

This seems like a different issue. I would recommend letting MailPoet support know about this. If you have contacted them about it they should be able to take a look.

[kriskarkoski]

@codemonkey-jack I'm not sure if it's related to the recent Jetpack update, but the media modal no longer works in MailPoet with Jetpack CDN on. I've disabled it for a user and confirmed that fixes this issue.

@carolynrosner In your Jetpack settings search "CDN" and turn off the "Speed up static file load times" option and let us know if that gets MailPoet working again for you. If not feel free to get in touch with us at wordpress.com/help/contact and we can help you further