Jellyfin-web: Redundant Disconnect Dialog

[iganeshk]

Redundant Disconnect Dialog
The web-server implementation of disconnecting from the chromecast/player prompts two dialog windows.

Additional context
ConfirmEndPlayerSession

[JustAMan]

These seem to be two different issues related to same component, please don't make single issue for several pieces. I would suggest you make a new issue for your point 2.

[iganeshk]

These seem to be two different issues related to same component, please don't make single issue for several pieces. I would suggest you make a new issue for your point 2.

Sure, filed it as a different issue.

[JustAMan]

Now back to your original issue, what is wrong with having a confirmation here?

[iganeshk]

Nothing really wrong but it seems to require additional step to disconnect when comparing it to the standard implementation of cast UX.

[dkanada]

It's not technically required, but most casting apps will either default to closing the stream if you disconnect or leaving it open. Currently we let the user choose, which I don't think is a bad idea in theory, but it does require an extra step.

[JustAMan]

We can probably have a checkbox in the first dialog, and remember user choice (whether it's ticked or not) in cookies.

[iganeshk]

Since this would be a user preference, how about having it as an option/checkbox under media playback or Remote control in user settings?

[dkanada]

I'd be fine moving it to the playback settings with a default of keeping the stream running.

[DMouse10462]

I think current behavior is best practice with some conditions; I certainly wouldn't consider leaving an application open on Chromecast uncontrollable as an ideal default and propose a flow similar to one when saving a document in an office suite:

As an alternative similar to YouTube (with only one controlling device), pressing Disconnect stops all media and shuts down the Chromecast app without any prompts whatsoever. Of course, YouTube has multi-seat queue capabilities which, if memory serves, keeps the app alive until all controlling devices have disconnected or a timeout with no playing media is reached.

[dkanada]

I might be inclined to just put a button next to disconnect that says shut down.

[hamburglar2160]

i recommend:

Completely doing away with the "shutdown confirmation."
Rename "disconnect" to "stop casting" to be more in line with guidelines and move that button to the "remote control" interface. Then do away with what remains.

[dkanada]

I'd rather not make changes to the remote control component, because that has to be as generic as possible to stay convenient.

[stale[bot]]

Issues go stale after 90d of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14d of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.