Jellyfin-web: Doesnt ask if I want to save password on successful login

[agilob]

Describe the bug
Doesnt ask if I want to save password on successful login

To Reproduce

1. Go login
2. Click type username and password
3. Should ask if I want to save username and password but doesnt

System (please complete the following information):

• OS: docker
• Browser: firefox 69.0.2
• Jellyfin Version: 10.4

[anthonylavado]

@Agilob Do you mean that Firefox (or other) doesn’t ask? I don’t think we have this feature ourselves because the “Remember Me” checkbox exists.

[agilob]

I can use "remember me" but when I remove cookies I want my username+pass saved in my browser ad synced between devices.

[anthonylavado]

@agilob Okay, so it is that the browser doesn't ask you if you want to save the username/password.

[stale[bot]]

Issues go stale after 90d of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14d of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

[agilob]

bump

go away bot, this is still an issue

[arantes555]

I've had this issue on some sites I wrote when the login form was not wrapped in a <form> element. For some reason, Firefox really needs to see a <form> in order to understand that there is something to remember.

(As a workaround, you can save the password manually in firefox's password manager. The auto-complete works a bit better and does not always need an actual <form> to auto-fill your passwords)

[ferferga]

I just pulled the changes and tested right now with master branch and Firefox prompted me for saving the password.

Can you test cloning master, so we can confirm this is fixed? (or installing jellyfin-nightly, which also has the latest changes)

PS: Tested in Firefox 72.0.2 (Windows x64)

[arantes555]

FYI Firefox changed a few things in the password manager recently, I believe it was in FF70.

[agilob]

The issue has been reported for firefox 69, day after new stable release of jellyfin.

[ferferga]

@agilob But it's fixed? Because in latest stable the login fields are wrapped inside <form> tags, so either @arantes555 is confused and that's not the problem or it's an issue that Firefox had for a while and it's now fixed.

[dkanada]

I just tried with Jellyfin Nightly and Firefox 72 and got a prompt.

[ferferga]

@dkanada Shall we close this?