Java: binary-search: update version file (v1.1.0 -> v1.2.0) and update error handling

Created on 28 Sep 2018  路  8Comments  路  Source: exercism/java

Please update the version specified in the binary-search version file from 1.1.0 to 1.2.0.

Please also make sure that the expected error handling in the robot-simulator tests is up to date with the canonical data for binary-search. Currently we expect a solution to binary-search to return -1 if the value searched for is not present. However the canonical data now indicates that this should cause an error in a way that is idiomatic to the language. I suggest throwing an exception in that case. Thoughts @exercism/java? 馃檪

After any changes have been made to the tests make sure that the reference solution still passes the tests. If it doesn't then please update the reference solution so that it passes all the tests.

Background info: each exercise which has canonical data should have a version file. This file states which version of the canonical data the exercise implements. The version can be found at the top of the canonical data file for that exercise.

code hacktoberfest

All 8 comments

I am working on this issue.

Had implemented this earlier with a new Exception. Made a PR regarding the same.

Oh no, I didn't see @anurag-rai already created a PR :) Closed mine.

@chungngoops Hey, I'm so sorry I didn't see your comment before making my PR. We had the same idea to use Exception though :)

@anurag-rai, no problem bro! Happy to work on other issues!

@FridaTveit @Smarticles101 is this issue still valid?

@RonakLakhotia Yes, it is 馃檪

I will attempt this issue and submit a PR. 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

FridaTveit picture FridaTveit  路  6Comments

Smarticles101 picture Smarticles101  路  4Comments

stkent picture stkent  路  5Comments

FridaTveit picture FridaTveit  路  4Comments

lemoncurry picture lemoncurry  路  3Comments