Java: grade-school: use assertEquals instead of assertThat

Created on 4 Oct 2018  路  4Comments  路  Source: exercism/java

In the grade-school tests assertThat is used for the test assertions. To be more consistent with the other exercises we should use assertEquals instead. For example:

assertThat(school.roster(), is(expected));

Should be changed to:

assertEquals(expected, school.roster());
code good first issue hacktoberfest

Most helpful comment

Changed for consistency, let me know if it needs more changes.

All 4 comments

Changed for consistency, let me know if it needs more changes.

I'll go for it.

@yuval105 Thanks for wanting to help but in this case @AndresAcuna got there first 馃檪 Feel free to work on any other issue or anything else you think needs improving! 馃檪

Thanks for getting this done @AndresAcuna - closing now as fixed in #1591

Was this page helpful?
0 / 5 - 0 ratings

Related issues

lemoncurry picture lemoncurry  路  3Comments

FridaTveit picture FridaTveit  路  6Comments

jtigger picture jtigger  路  3Comments

dawcars picture dawcars  路  7Comments

stkent picture stkent  路  5Comments