v2.8.0go-ipfs v0.5.0-rc4tx pull -a)go-ipfspackage.jsongit tag $versiongit push && git push --tagspackage.jsongit tag $versiongit push && git push --tags.dmg at Apple (context: #1365).dmg from https://github.com/ipfs-shipyard/ipfs-desktop/releases/vA.B.CAPPLEID and APPLEIDPASS are set either as environment variables or entries in .env file. Those need to belong to the same org as cert used for signing.node pkgs/macos/notarize-cli.js ./IPFS-Desktop-A.B.C.dmg_If any..._
Note: update to electron 8 broke tray icon on verious Linux setups, making it impossible to start/stop the node, nor open webui β see https://github.com/ipfs-shipyard/ipfs-desktop/issues/1153#issuecomment-596780147
Releasing this would introduce regression for existing users.
We need to either revert that update, or figure out a way of solving the Linux problem.
Hmm. Youβre right. Honestly I doubt Electron/Chromium folks are going to fix this soon. Itβs been years talking about Linux and its Tray icons and nothing has been done.
One one hand, I donβt want to prevent Linux users to have access to IPFS desktop. On the other hand, I donβt want to keep using an old version of Electron ad infinitum when there are no assurances that this will be fixed.
Iβll revert this for now (will do tomorrow) but we need to find a solution.
I agree, but I don't believe we should revert this: getting the latest Electron fixes are probably more important than keeping legacy tray support on Linux.
We just need to have UX workaround in place for Linux before 0.11 ships (show webui when ipfs-desktop is called while it is already running, or could be a custom popup, could be extensive "Tray on Linux" section in README etc β need to think about)
Okay, let's find out a way!
Hey Folks! Flagging this for the go-ipfs 0.5 release train. go-ipfs RC-4 (https://github.com/ipfs/go-ipfs/issues/7109#issuecomment-619351992) has the final changes prior to release next week. We'd like the network to update ASAP to 0.5 so that everyone can experience the performance improvements. If this desktop release is currently blocked on the Linux issues mentioned above, can we cut an intermediary release which will help upgrade desktop users to 0.5.0 next week?
Should there be anything in these release steps about MacOS notarization too? (https://github.com/ipfs-shipyard/ipfs-desktop/pull/1365#issuecomment-596727138)
@momack2 #1429 should unblock this. Just waiting for review! π
The notarization thingy was released/fixed with v0.10.4.
Notarization is still a manual step that needs to happen before publishing release draft on github. I added it to the checklist before "Ship" step, to ensure we don't forget.
Ok, I believe we reviewed and merged key PRs (Linux is unblocked by #1429) and figured out notarization plan. More or less just waiting for 0.5 to land.
Things that need to happen before release:
master with go-ipfs 0.5.0-rc4 (on Mac&Windows)master of webui includes drag&drop fix by @rafaelramalho19 (https://github.com/ipfs-shipyard/ipfs-webui/pull/1468) and may solve issues described in https://github.com/ipfs-shipyard/ipfs-desktop/issues/1287#issuecomment-580368657notarize-cli.js, as noted in https://github.com/ipfs-shipyard/ipfs-desktop/pull/1365#issuecomment-596727138)We switched to ipfs-webui 2.8.0 and drag&drop issues should be gone.
@rafaelramalho19 is taking a look at the remaining problem with adding folders via button (drag&drop works: https://github.com/ipfs-shipyard/ipfs-desktop/issues/1287#issuecomment-620604299).
Would be nice to include a fix for that in this release, but if the fix takes longer we can always ship it later as a patch release (it was already broken in ipfs-desktop v0.10.4 too, so no regression for existign users) β priority here is switching desktop users to go-ipfs 0.5.
I'm currently correcting translations in French for IPFS Desktop and the Web UI, if you can afford to wait 1h.
Done. You may want to reimport translations for Web UI, Desktop, Share files, Companion and IPLD explorer.
Thank you @bertrandfalguiere!
@jessicaschilling @rafaelramalho19
I checked in with go-ipfs team and we are prioritizing shipping go-ipfs 0.5 to users, so we will cut 0.11.0 today with Desktop translation updates and go-ipfs 0.5 and later this week ship a patch release of Desktop (0.11.1) with fix for https://github.com/ipfs-shipyard/ipfs-desktop/issues/1287#issuecomment-620604299 and any missed translation updates in webui.
(tagged and built v0.11.0, waiting for macOS notarization before publishing release)
Applied two hotfixes, recreating release:
Can the Linux & Windows binaries be published before the ones for MacOS?
Thank you @bertrandfalguiere!
@jessicaschilling @rafaelramalho19
I checked in with go-ipfs team and we are prioritizing shipping go-ipfs 0.5 to users, so we will cut 0.11.0 today with Desktop translation updates and go-ipfs 0.5 and later this week ship a patch release of Desktop (0.11.1) with fix for #1287 (comment) and any missed translation updates in webui.
Apparently, traductions from ipld-explorer-components should be pulled and bubbled too, according to: https://github.com/ipfs-shipyard/ipfs-webui/issues/1477#issuecomment-620838432
:)
@NatoBoram sadly the current setup (based on https://www.electron.build/auto-update.html) is all-or-nothing: we are unable to publish a release to the official channel without impacting Mac users.
That being said, if you want to help us _testing_ v0.11.0 on Linux,
here are binaries that are waiting for publishing:
bafybeiegs4nplthqhneuhsm6n7qwczswf7yjr77yeimwbvkpi5mmewdrxm
Let us know if anything looks odd, note the Tray issues on Linux (#1153 / https://github.com/ipfs-shipyard/ipfs-desktop/pull/1466)
@NatoBoram The Linux version was published a few hours ago on snap (now the default on Ubuntu 20.04).
@lidel is the realese on snap an independant/parallel process of/to realeases elsewhere?
@bertrandfalguiere it is a single build pipeline, but since https://github.com/ipfs-shipyard/ipfs-desktop/pull/1157 snap is published to snapstore instead of being attached to a draft of a github release.
Shipped: v0.11.1 :ship:
Most helpful comment
Ok, I believe we reviewed and merged key PRs (Linux is unblocked by #1429) and figured out notarization plan. More or less just waiting for 0.5 to land.
Things that need to happen before release:
masterwith go-ipfs 0.5.0-rc4 (on Mac&Windows)masterof webui includes drag&drop fix by @rafaelramalho19 (https://github.com/ipfs-shipyard/ipfs-webui/pull/1468) and may solve issues described in https://github.com/ipfs-shipyard/ipfs-desktop/issues/1287#issuecomment-580368657notarize-cli.js, as noted in https://github.com/ipfs-shipyard/ipfs-desktop/pull/1365#issuecomment-596727138)