Ipfs-desktop: Unable to add folders via Files screen

[thimper]

macos : 10.13.6

Adding folders has no effect。

Using the command line ipfs add-r folders is fine

[autonome]

Thanks for reporting!

Confirmed on Mac OS X 10.14.6 with IPFS Desktop 0.10.2

STR:

• Open web UI to files page
• Click [+Add]
• Select "Folder"
• Choose a folder

Expected: Folder is added and is visible in UI

Actual: Nothing happens

@hacdias or @lidel any ideas what caused regression?

[hacdias]

Unfortunately, I have no idea and there are no errors reported in the console. In the meanwhile, you can just drag'n'drop directories to the menubar icon! That should work

[lidel]

Just for the record, this does not not seem to be limited to Electron.
IIUC the same problem was confirmed on Google Chrome Canary.
Tracked in https://github.com/ipfs-shipyard/ipfs-webui/issues/1367#issuecomment-567924016

[lidel]

Ok I think there are two bugs at play here. Dumping my notes for future reference.

I tested on Linux with Electron/Firefox/Chromium, and:

• if webui is opened in Electron (ipfs-desktop)
  
  
  
  • :anger: adding folder does not work via button (no error in Console)
  
  
  • :anger: adding folder does not work via drag&drop (error)
  
  
  • :anger: adding single file does not work via drag&drop on Linux (same startsWith error)
  
  

• if webui is opened in Firefox 72

  • :angel: adding folder WORKS via button
  • :anger: adding folder does not work via drag&drop (error)

• if webui is opened in Brave (Chromium 77)

  • :angel: adding folder WORKS via button
  • :anger: adding folder does not work via drag&drop (error)

Update: confirmed to be a problem on windows as well: https://github.com/ipfs-shipyard/ipfs-desktop/issues/1346

[lidel]

I believe https://github.com/ipfs-shipyard/ipfs-webui/pull/1468 fixes all/most of drag&drop issues described in https://github.com/ipfs-shipyard/ipfs-desktop/issues/1287#issuecomment-580368657, thank you @rafaelramalho19 :-)

When we release new webui and switch ipfs-desktop to the new version we can check if this issue can be closed (or comment what remains to be fixed).

[lidel]

@rafaelramalho19 FYSA I retested with webui v2.8.0 (PR #1457) on Linux with Electron/Firefox/Chromium, and:

• if webui is opened in Electron (ipfs-desktop)
  
  
  
  • :anger: adding folder does not work via button (no error in Console)
  
  
  • :angel: adding folder WORKS via drag&drop
  
  
  • :angel: adding single file WORKS via drag&drop
  
  
• if webui is opened in Firefox
  
  
  
  • :angel: adding folder WORKS via button
  
  
  • :angel: adding folder WORKS via drag&drop
  
  
• if webui is opened in Brave (Chromium)
  
  
  
  • :angel: adding folder WORKS via button
  
  
  • :angel: adding folder WORKS via drag&drop
  
  

So after we merge #1457 the only thing that needs to be fixed is adding folder via button in Electron.

[rafaelramalho19]

Thanks for testing that out @lidel.

I'll see what's wrong with the button

[hacdias]

💢 adding folder does not work via button (no error in Console)

@lidel it does now thanks to @rafaelramalho19's work :smiley: Thank youu

[lidel]

All fixed in v0.11.2
Upgrade ASAP :-)