Iot: SoftwarePwmChannel should be in System.Device.Pwm

Created on 4 Jan 2020  路  3Comments  路  Source: dotnet/iot

Currently SoftwarePwmChannel exists in System.Device.Pwm.Drivers which is inconsistent with PwmChannel. It should be moved to System.Device.Pwm.

Please let me know what you think before I make any changes

cc: @joperezr @Ellerbach

area-device-bindings bug

All 3 comments

Agreed. I鈥檓 assuming this will eventually be moved to the core library (similar to what you previously mentioned about moving the software SPI). If that is not the intention, it might be worth to go ahead and also rename SoftPwm folder to SoftwarePwm.

@shaggygi yes, I hope it will be moved eventually although I think it should pass all our tests first which currently it doesn't (Windows is running against it as fallback).

I agree with @shaggygi and would only do this once we can a) rename this to SoftwarePwm and b) move it down to System.Device.Gpio. That is the right place for it anyway and I think doing these 3 steps separately makes no sense, so lets just do all three together.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mskuratowski picture mskuratowski  路  3Comments

Ellerbach picture Ellerbach  路  6Comments

MarkCiliaVincenti picture MarkCiliaVincenti  路  6Comments

alex182 picture alex182  路  6Comments

JPThorne picture JPThorne  路  6Comments