Ionide-vscode-fsharp: Invalid signatures in tooltips

[matthid]

I would assume this is an issue in visualfsharp but just to be sure I first wanted to report this here.
The problem disappears when renaming the "exception" parameter to something else. In fact the signature was just copied from the ILogger tooltip.

[Krzysztof-Cieslak]

For the errors we just feed editor with the errors provided by FCS, we have no impact on it.

[matthid]

Ok I reported the first part to visualfsharp. Let me try again:

How are the signatures reported? This one is not correct. Can we rename keywords or put them in ``?

[inosik]

Should we add the exception keyword to the grammar?

Nevermind, it already is.

[Krzysztof-Cieslak]

Yeah... I probably don’t add double backticks in the tooltips at all, I bet it’s broken for other cases too, not only exception keyword. The bug is in the signature or tooltip formatted in FSAC if anyone would want to work on it

[7sharp9]

So if paramName isKeyword then sprintf "``%s``" paramName else paramName

[Krzysztof-Cieslak]

@7sharp9 it's probably not just keywords but also other doubleticked things are wrong. But yes, it's simple bug to fix ;-)

[7sharp9]

Actually, I think there a function in the compiler to get back a mangled name etc

[Krzysztof-Cieslak]

PrettyNaming.QuoteIdentifierIfNeeded

[7sharp9]

@Krzysztof-Cieslak Can you assign this for me to do?

[7sharp9]

first part patched

[7sharp9]

This is now fixed.