Ionide-vscode-fsharp: Member signature missing arrow, looks like property

[klettier]

Hello,

Ionide version: 3.20.4

[Krzysztof-Cieslak]

@priort, any ideas?

[priort]

Damn, most likely from my change to make getter signatures the same as code lens
https://github.com/fsharp/FsAutoComplete/commit/c5c8e0d4766b6a5d1e6d62a1258fa3a148a8566e

This check here symbol.IsPropertyGetterMethod
that probably includes methods as well as properties - there is probably something else on the symbol that we can check instead.
I don't have FSAC on my machine at the moment but hopefully I'll get a chance on the weekend to check it out again and fix this.

[priort]

I'm not totally sure yet if its related to my fix for this https://github.com/ionide/ionide-vscode-fsharp/issues/789

It seems fine on class members.

Also the abstract member signature in the Interface itself seems fine:

But I see the issue on abstract class members:

and interface member impls signatures:

I'll have to debug in FSAC to investigate what's happening with abstract class member and impls of abstract members signatures.

[priort]

on override __.Y() = 4, the IsPropertyGetterMethod on the symbol in fsac returns false

So it doesn't look like this issue is due to the IsPropertyGetterMethod check that I added.
I think its happening later on in the processing in FSAC. I'll investigate more tomorrow or in next day or so.

[priort]

@klettier @Krzysztof-Cieslak
I fixed the issue on FSAC and put in a PR here https://github.com/fsharp/FsAutoComplete/pull/293
The PR has screenshots of the fix in action.

[Krzysztof-Cieslak]

Released in 3.20.5

[priort]

Cool, thanks!