Ionic-framework: Improve Slides

[brandyscarney]

Known issues:

• [x] Pager is an attribute - probably want to use the swiper version - options
• [x] Multiple sliders on one page use the same pagination
• [x] Improve documentation behind options and methods
• [ ] Remove timeout around create
• [ ] Don't emit slide events when runCallbacks is false

[steveharbick]

I'm hoping there is (to be documented), or will be (added), a way to access the Swiper API's method: mySwiper.slideTo(index, speed, runCallbacks). This is particularly useful for using slides on first-run and allowing user to skip to end if they want.

[brandyscarney]

@steveharbick There's actually been a PR submitted for this it's just something we need to look into merging. :smile: https://github.com/driftyco/ionic/pull/5491

[adamdbradley]

Related: https://github.com/driftyco/ionic/issues/6198

[brandyscarney]

So some of the improvements were made. I improved the docs to add a lot more information and document the methods better, these can be seen here: http://ionicframework.com/docs/v2/api/components/slides/Slides/

Please check the changelog for the breaking changes to slides in beta.5: https://github.com/driftyco/ionic/blob/2.0/CHANGELOG.md#200-beta5-2016-04-20

Let me know if you have any feedback on the docs! Going to move this issue to beta.6 to continue work on it.

[davyzhang]

slideTo marked time is an optional parameter, but can not omitted in typescript

    /**
     * Transition to the specified slide.
     *
     * @param {number} index  The index number of the slide.
     * @param {number} speed  Transition duration (in ms). Optional.
     * @param {boolean} runCallbacks  Whether or not to emit the `willChange`/`didChange` events. Optional. Default true.
     */
    slideTo(index: number, speed: number, runCallbacks: boolean): void;

Should it be
slideTo(index: number, speed?: number, runCallbacks?: boolean): void;

?

[brandyscarney]

Thanks for pointing that out @davyzhang, I fixed it in the source so it should be in the next release! Sorry about that. :smile:

[davyzhang]

Fantastic, Thanks for the great work.

[ramonornela]

Related: #7422

[brandyscarney]

Closing this since slides have been refactored.

[tmk1991]

Any update on having multiple sliders on one page?

[btribouillet]

Any update on having multiple sliders on one page?

Indeed it would be great! I was amazed about this component but it is too bad we can't use multiple sliders on one page.

[ionitron-bot[bot]]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.