Incubator-superset: [🎉New Feature for Testing]Dashboard native filter and cascading filter are HERE!

[junlincc]

Highly requested from the community for a couple of years, Superset's new Dashboard Native Filter and Cascading Filter are finally available, ready for testing in master!! We welcome your feedback and comments!

It has been a six months long collaborative project leading by @suddjian, with the dedicated effort from multiple developers.
Credit goes to the below awesome contributors ♥️
@suddjian @villebro @pkdotson @rusackas @mihir174(design)
@agatapst @adam-stasiak
@amitmiran137 @simchaNielsen

special thanks to @graceguo-supercat @ktmud @zuzana-vej for user research and code review!

This feature is currently behind a feature flag, to turn on

1. go to docker/pythonpath_dev/superset_config.py
2. add below

 FEATURE_FLAGS = {
    "DASHBOARD_NATIVE_FILTERS": True,
}

Features include
Changes included in feat(dashboard): Dashboard-Native Filters #11814 and feat: Native filters fast-follow #12138:

• Dashboard-native filters can be created, edited, and deleted from the Dashboard in View Dashboard mode
• Filters can be scoped to specific dashboard panels
• Filter indicator compatibility
• Cascading filters(setting parent filter)
• Instant apply value
• Default values
• Collapsible left panel
• Reset all
• and much better UX!
• .......
  WIP
• Time range filter

Create new filter

Filter scoping

Cascading filter hierarchy setting


Open and Collapse side bar

[junlincc]

[assigned:polidea][dashboard]native filter sidebar styling and padding should be consistent with the Data panel in Explore
Data Panel in Explore

Native Filter in Dashboard

[junlincc]

[assigned:polidea][dashboard]native filter RESET ALL button does not work properly

https://user-images.githubusercontent.com/67837651/102756804-45460600-4325-11eb-8251-d326b0173f80.mov

[junlincc]

[assigned:polidea][dashboard]new native filter loading state should show Superset infinite loading icon instead of "No Results"

https://user-images.githubusercontent.com/67837651/102757345-095f7080-4326-11eb-9ca3-deea6df33143.mov

[zhaoyongjie]

[assigned:polidea][dashboard] This looks like the Native Filter and Chart filter indicator do not match.

[zhaoyongjie]

[dashboard] Timestamp/Datetime-like column is not handled correctly

Filter settings

Error

[zhaoyongjie]

[assigned:nielsen][dashboard] Apply to specific panels not work.

https://user-images.githubusercontent.com/2016594/102797331-82c09700-43ea-11eb-935b-c31c14825387.mov

[amitmiran137]

@zhaoyongjie thank you for sharing
we will take of it
cc: @junlincc @villebro @simchaNielsen

[adam-stasiak]

[assigned:polidea][DASHBOARD]
SCENARIO:
To tabbed dashboard add filter with country name default value: United States
Save
Apply filter With name CHINA
Click on Reset -> Now filter box shows the default value
Click on APPLY -> Default Filter value is not applied

Expected: After click on APPLY it should be current field value applied.
https://user-images.githubusercontent.com/25153919/102827412-cfa06f80-43e2-11eb-9bff-3591138f97ae.mov

[adam-stasiak]

[dashboard]
Scenario:
Create Filter with reference to dataset
Delete this dataset
Go back to Filter Configuration and Scoping:

Observed: You can find that *FIELD has looped loading animation with name of not available field. After I choose different datasource I still see this old type of field as an option in field box.

Expected: We should indicate somehow that Filter is malformed(@junlincc) and do not propose not available options to set.

https://user-images.githubusercontent.com/25153919/102828444-07a8b200-43e5-11eb-9f82-0e4351590e7b.mov

[adam-stasiak]

[dashboard]
Steps to reproduce:
Add very long name of filter

Observed: You can see that UI glitches. We should handle this better -> I suggest adding in the left side section "..." at the end of too long names or splitting into lines.

https://user-images.githubusercontent.com/25153919/102829427-64a56780-43e7-11eb-9817-cc3034564a83.mov

[adam-stasiak]

[dashboard]
Weird behavior for me.

When I add two new filters and:

• first is correctly filled
• second is partially filled
  And I click on Save on first filter -> I do not get information that this SAVE will not keep my filter when I quit this modal.

We should indicate that progress will be lost and:

• force user to finish or remove remaining filters before exit
• discard not valid filter entries
• keep them as draft not applicable for usage

@junlincc I think we should consider options for this.

https://user-images.githubusercontent.com/25153919/102830600-f31ae880-43e9-11eb-9583-93dc47f5909d.mov

[adam-stasiak]

[dashboard] This looks like the Native Filter and Chart filter indicator do not match.

I agree- > When we set Native Filter set then we can clearly see number indicator so we should place there native filters as well and update the counter

[adam-stasiak]

[dashboard]

Default value for filter is not exported with dashboard.
Scenario:
Create Filter with default value.
Export dashboard
Import json file of dashboard

You can see that Default Value for filter was not exported - > Information about Parent relation was exported so I think it should be as well.

[simchaNielsen]

[dashboard] Apply to specific panels not work.

Screen.Recording.2020-12-22.at.12.10.32.AM.mov

We will process fix for it in few steps.

1. UI Config Modal fix:
   https://github.com/apache/incubator-superset/pull/12171
   cc: @amitmiran137 @villebro

[adam-stasiak]

[dashboard]
When only 1 option is available in filter then it is displayed 1 option()