Incubator-superset: Add New button visible for users without permissions

[gbrian]

The "Add New" buttom appears when user has no permissions.
Superset shows the "Add New" button for users without permissions.

Expected results

Visible if the user has permissions on one or more options

Actual results

User clicks and gets back to main page

Screenshots

How to reproduce the bug

1. Create a user without any permissions
2. Log in superset

Environment

(please complete the following information):

• superset version: Superset 0.999.0dev
• python version: Python 3.7.2
• node.js version: v10.15.0
• npm version: 6.4.1

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• [*] I have checked the superset logs for python stacktraces and included it here as text if there are any.
• [*] I have reproduced the issue with at least the latest released version of superset.
• [*] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.69. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[ohoroyoi]

I think this feature is really needed

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.