Incubator-superset: Fail to load "Explore Chart" views using slice ids in superset 0.38.0.rc2

[lilila]

I am testing the new version superset 0.38.0.rc2 and I have issues loading charts in the "Explore Chart" view.

When I "explore" a table, it works well, and I can see in the URL the all options are passed (form_data, query_fields .... )
It also works for Big Number, Big Numbers with trendlines

When I try to "explore" a line chart, a map ... I get an empty view. I notice it fails when the chart is specified by its slice_id in the url (e.g superset/explore/?form_data=%7B"slice_id"%3A1676%7D).

In the console log I have the following errors:

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.90. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[bryanck]

Same problem here, getting TypeError: Cannot read property 'id' of undefined when loading a chart in the Chart editor, either from the "Explore chart" menu item on a dashboard, or simply from the "Charts" list. This happens with most chart types, except tables seem to be OK.

[bryanck]

This may be a backwards compatibility issue. If I create a brand new chart, then I don't seem to have this issue, it seems to happen only for charts that were created before 0.38rc2.

[villebro]

Might have something to do with default control state. Let me look into this.

[villebro]

I was finally able to reproduce 👍 Investigating

[villebro]

I have now identified the necessary fix, will start working on rc3 shortly.

[villebro]

@lilila @bryanck feel free to try out the pre-release of rc3: https://github.com/apache/incubator-superset/commits/0.38

[lilila]

@villebro it works well, you are the best!

[bryanck]

Appears to be fixed for me as well!

[junlincc]

Thank you Ville! @villebro closing this issue!

@mistercrunch FYI

[villebro]

Awesome, thanks for confirming @lilila and @bryanck !