Incubator-superset: Dashboards: Can't use charts that you own but didn't create

[rwspielman]

When looking at "Your charts and filters" in Dashboard edit mode, visualizations that you are a listed 'owner' on, but didn't create, don't appear in the list.

Expected results

Given the selection is "your charts and filters", I would expect it to include charts/filters that you own, not just charts/filters that you created.

Actual results

Only charts that you are the creator of appear in the list. This hinders collaborative work

Screenshots

Caleb Reed is creator:

Rob Spielman is owner:

Not appearing in "Your charts and filters"

How to reproduce the bug

1. Login as User 1
   1a. Create a chart
   1b. Add user2 as owner in addition to User1
2. Login as User 2
   2a. Go to a dashboard and edit
   2b. Search for that chart name in "Your Charts and Filters"
   2c. Observe it does not show up

Environment

(please complete the following information):

• superset version: superset version 0.37.2
• python version: python --version 3.6.9
• node.js version: node -v 8.10.0
• npm version: npm -v 3.5.2

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
• [x] I have reproduced the issue with at least the latest released version of superset.
• [x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.89. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[rwspielman]

If you change line 48 in /superset-frontend/src/dashboard/actinos/sliceEntities.js to
endpoint: `/sliceasync/api/read?_flt_0_owners=${userId}`,
it should close this issue

https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/dashboard/actions/sliceEntities.js

[nytai]

@rwspielman You should still be able to add the chart to the dashboard via the chart explore page as a workaround.

[rwspielman]

@nytai Thank you! somewhat unrelated to the issue, but our organization would benefit from separate permissions that allow users to use charts in a dashboard without being the owner. i.e. read-only access to a dashboard. we could just remove the filter on this query, but that sort of opens up every chart to all users which could be a very large list