Incubator-superset: Timer in SQL Lab and Explore doesn't work

[zuzana-vej]

A clear and concise description of what the bug is.
The timer in SQL Lab doesn't work. When you run the query 1st time, it shows some number (unsure if accurate). When you run a query 2nd time the value on the timer doesn't change.

Expected results

The timer should reset every time user hits the "RUN" button, and start counting again from 0.

Actual results

Timer is stuck.

Screenshots

Step 1: Running 1st query: (timer has some result, which looks inacurate, the query took longer than 0.67 sec

Timer detail:

Step 2: Change to different SQL Lab tab and run 2nd query:

Timer detail:

See query is running - timer value doesn't change

Timer detail:

Query finished and returned result - timer is still displaying same value as before hitting RUN button:

Timer detail:

How to reproduce the bug

1. Go to SQL Lab
2. Click on RUN query
3. See the timer and whether it changes
4. Run query again, see the timer and whether it changes

Environment

• superset version: latest

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
• [x] I have reproduced the issue with at least the latest released version of superset.
• [x] I have checked the issue tracker for the same issue and I haven't found one similar.

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.98. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[junlincc]

thanks for reporting the timer issue.

[john-bodley]

Note I believe the timer is also broken in explorer as well.

[zuzana-vej]

Yes, correct, it happens on Explore as well. Here is an example:

1. Clicked to refresh the chart (which was previous cached). While query is running, it displayed this timer: (even right after click it says 5s)
   
2. Once query finished, timer looks like this (query took longer than 5 seconds):
   

[junlincc]

@tanmaylaud @rusackas

[tanmaylaud]

@JunlinC @rusackas I haven't been able to reproduce this issue locally. The master branch seems to be working fine.
Here's a video of me running the queries: https://www.youtube.com/watch?v=RTr0lXGjrO0

[junlincc]

@Zuzana Vejrazkova [e-mail] it works fine for me as
well. also, I believe that the timer is showing 5 millisecond instead of 5
secs? could you provide a .gif or video? Thanks!

Thank you Tanmay for looking into this!

On Sat, Sep 19, 2020 at 1:58 AM Tanmay Laud [e-mail]
wrote:

@JunlinC https://github.com/JunlinC @rusackas
https://github.com/rusackas I haven't been able to reproduce this issue
locally. The master branch seems to be working fine.
Here's a video of me running the queries:
https://www.youtube.com/watch?v=RTr0lXGjrO0

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/issues/10849#issuecomment-695186907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQFR5U6VOTJK7YDCYCXXTXTSGRXCDANCNFSM4RIV7YJQ
.

[zuzana-vej]

@tanmaylaud can you confirm which version you see this is working as expected? (the latest superset release or master ( and master as of which day))? Everyone from our team sees the same issue. Is it possible that it was fixed recently (within last few days)? I shared couple videos with Junlin directly, she can share the folder with you.

[graceguo-supercat]

@tanmaylaud please run a longer query in SQL lab. in your example, query is too short that you can't tell if Timer display a correct running time.
Run a query like select * from wb_health_population limit = 500.
This is what i experienced: Note i clicked run button twice, the timer didn't even reset to 0

[zuzana-vej]

We believe the issue is with this PR https://github.com/apache/incubator-superset/commit/a6fa02aaec1ec5cba1fa010cf6910f65a965eaf7 (reverting it locally fixes the timer issue locally). I can slack you link to the video recording.

[mistercrunch]

revert?

[junlincc]

thanks @ktmud for fixing!