Incubator-superset: Allow reordering of table view columns

Created on 26 Mar 2019  路  7Comments  路  Source: apache/incubator-superset


Make sure these boxes are checked before submitting your issue - thank you!

  • [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [x] I have reproduced the issue with at least the latest released version of superset.
  • [x] I have checked the issue tracker for the same issue and I haven't found one similar.

Superset version

Commit SHA: b3c4bd95efd5f74e822b7ed7a2db043ba7b8c6cf

Problem

Columns displayed in the table view should be rearrangeable once chosen. They always follow the order in which they were selected, so that if you want the last column to be the first one, you have to remove all the columns and select them again in the correct order. An image of the current column selector is shown below:
image
This issue also happens on the GROUP BY columns.

Possible solution

This could be solved by using the controller used in the Filter Box visualization to select the available filters:
image
In that case, it is possible to rearrange the filters as desired without deleting and adding them again and again.

.pinned request

Most helpful comment

react-select added support for this last month, but it looks like it hasn't been baked into a release yet. I expect it'll probably be in 3.1.0 whenever that is drafted.

All 7 comments

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

Ideal would be for someone to contribute the feature in react-select https://github.com/JedWatson/react-select/issues/3223 , please add a "thumbs up" on the issue!

react-select added support for this last month, but it looks like it hasn't been baked into a release yet. I expect it'll probably be in 3.1.0 whenever that is drafted.

The react-select has released version 3.1.0 which has this feature. https://react-select.netlify.com/advanced#sortable-multiselect .

However, the react-select library for superset is currently at
"react-select":"1.2.1",

Are there plans to upgrade it to solve the problem?

This has been implemented in Superset.

https://github.com/apache/incubator-superset/pull/9628

If someone could help testing this PR, that'd be great!

馃檹@mistercrunch this issue can be closed

Closing as completed.

Was this page helpful?
0 / 5 - 0 ratings