Incubator-superset: [Event Flow Viz] When hovering or interacting with chart, everything disappears

[vylc]

Errors on JS console:
vendors-addSlice-dashboard-profile-welcome.77167b2494c02e8d12f9.chunk.js:41 Error: Minified React error #188; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=188 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at r (vendors-EventFlow.0f0944afee5e19827565.chunk.js:29)
at m (vendors-EventFlow.0f0944afee5e19827565.chunk.js:29)
at bn (vendors-EventFlow.0f0944afee5e19827565.chunk.js:29)
at Object.findHostInstance (vendors-EventFlow.0f0944afee5e19827565.chunk.js:29)
at vendors-EventFlow.0f0944afee5e19827565.chunk.js:29
at Object.fe [as findDOMNode] (vendors-EventFlow.0f0944afee5e19827565.chunk.js:29)
at n.value (vendors-EventFlow.0f0944afee5e19827565.chunk.js:23)
at fa (vendors-addSlice-dashboard-profile-welcome.77167b2494c02e8d12f9.chunk.js:41)
at ca (vendors-addSlice-dashboard-profile-welcome.77167b2494c02e8d12f9.chunk.js:41)
at sa (vendors-addSlice-dashboard-profile-welcome.77167b2494c02e8d12f9.chunk.js:41)
ii @ vendors-addSlice-dashboard-profile-welcome.77167b2494c02e8d12f9.chunk.js:41
vendors-addSlice-dashboard-profile-welcome.77167b2494c02e8d12f9.chunk.js:41 Uncaught Error: Minified React error #188; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=188 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at r (vendors-EventFlow.0f0944afee5e19827565.chunk.js:29)
at m (vendors-EventFlow.0f0944afee5e19827565.chunk.js:29)
at bn (vendors-EventFlow.0f0944afee5e19827565.chunk.js:29)
at Object.findHostInstance (vendors-EventFlow.0f0944afee5e19827565.chunk.js:29)
at vendors-EventFlow.0f0944afee5e19827565.chunk.js:29
at Object.fe [as findDOMNode] (vendors-EventFlow.0f0944afee5e19827565.chunk.js:29)
at n.value (vendors-EventFlow.0f0944afee5e19827565.chunk.js:23)
at fa (vendors-addSlice-dashboard-profile-welcome.77167b2494c02e8d12f9.chunk.js:41)
at ca (vendors-addSlice-dashboard-profile-welcome.77167b2494c02e8d12f9.chunk.js:41)
at sa (vendors-addSlice-dashboard-profile-welcome.77167b2494c02e8d12f9.chunk.js:41)

Make sure these boxes are checked before submitting your issue - thank you!

• [ ] I have checked the superset logs for python stacktraces and included it here as text if any
• [ ] I have reproduced the issue with at least the latest released version of superset
• [ ] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

Expected results

Actual results

Steps to reproduce

[jnishiyama]

I'm experiencing the same issue.

[jnishiyama]

@williaster You wouldn't happen to have any ideas here, would you? This bug is a blocker for EventFlow usage. I'd be more than willing to tackle the problem, but would need someone to point me in the right direction.

It almost seems as though multiple versions of React are being loaded, but I can't confirm. From my understanding of the stack trace that I get, it's coming from withBoundingRects in @vx/bounds when it's called from the EventFlow Tooltip. Embarrassingly enough, I haven't figured out a good way to mess around with the module inside of the Superset project, so I don't have better information than that.

[williaster]

Sorry this one snuck by me, I'm pretty sure this error comes from React 15 being bundled with the visualization, which is incompatible with having React 16 present in the Superset app.

This may take me a day or two as the @data-ui library has a broken build that's been tricky to fix, but I had planned on working on it this week 👍

[jnishiyama]

@williaster left PR to fix build-config for data-ui and PR to bump @data-ui build-config version (to theoretical next version).

Will the upgrade to React 16 be simple?

[williaster]

thanks @jnishiyama, just responding to those now. Superset is on React 16 and event-flow should also be compatible with that (just need a new release when the build is fixed).

When bumping the @data-ui/event-flow dep in Superset we'll also need to add add aphrodite as a dep (because it was incorrectly bundled along with React). Ideally we'd remove that because it's pretty heavy, but don't have bandwidth to take that on rn.

[williaster]

Hmm trickier than I thought. I can get it to work in isolation in a code sandbox with different react versions, but still breaks in Superset. will continue to debug.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[kamalsky]

Hi @williaster! Any luck with this viz? An upgrade to React 16 a good fix?

[williaster]

This is fixed in our current deployment which is decently close to master.

[hyguod]

how to resolve it @williaster

[nabinkhadka]

What is the fix @williaster ?

[williaster]

This vis is being deprecated/no longer supported in data-ui, so we should likely remove it from the plugins.

See here for more https://github.com/williaster/data-ui/issues/201