Imgbrd-grabber: ..jpg

[ReverieEmanon]

What steps will reproduce the problem?

canceling a download?

What is the expected behavior? What do you get instead?

Images from zerochan should download. Instead out of the 100 or so images to download only 1 goes through and I get a message saying 1 downloaded 99 already saved when there is none in that folder

How often does this problem occur? On which sources?

100% of the time. only on Zerochan

What version of the program are you using? On what operating system?

5.52

Please provide any additional information below

that 1 image downloaded is always labeled ..jpg.
I've also tried uninstalling and reinstalling.

[Gaffnet]

It seems to be an MD5 signature processing issue.

Grabber is using a blank MD5 value for images from ZeroChan, and that Grabber appears to consider an empty MD5 signature as a valid MD5 signature. The result is that from Grabber's perspective, all images on ZeroChan have the same (blank) MD5 signature and therefore they're all duplicates and shouldn't be downloaded.

So if you're using %md5%.%ext% as your filename format, your filename will contain just the file extension when the MD5 signature is missing.

Log:

[08:59:15.915][Info] Batch download started. [08:59:15.923][Info] All images' urls have been received (5). [08:59:15.926][Info] Downloading images directly. [08:59:15.928][Info] Loading image from https://static.zerochan.net/full/39/18/2220939.jpg 1 [08:59:15.929][Info] MD5 "" of the image https://static.zerochan.net/full/39/18/2220939.jpg already found in file h:\t\artist-unk src-unk char-unk 20171129 tags- (unknown).jpg [08:59:15.931][Info] Loading image from https://static.zerochan.net/full/30/18/2220930.jpg 1 [08:59:15.931][Info] MD5 "" of the image https://static.zerochan.net/full/30/18/2220930.jpg already found in file h:\t\artist-unk src-unk char-unk 20171129 tags- (unknown).jpg [08:59:15.934][Info] Loading image from https://static.zerochan.net/full/31/18/2220931.jpg 1 [08:59:15.935][Info] MD5 "" of the image https://static.zerochan.net/full/31/18/2220931.jpg already found in file h:\t\artist-unk src-unk char-unk 20171129 tags- (unknown).jpg [08:59:15.937][Info] Loading image from https://static.zerochan.net/full/32/18/2220932.jpg 1 [08:59:15.938][Info] MD5 "" of the image https://static.zerochan.net/full/32/18/2220932.jpg already found in file h:\t\artist-unk src-unk char-unk 20171129 tags- (unknown).jpg [08:59:15.939][Info] Loading image from https://static.zerochan.net/full/33/18/2220933.jpg 1 [08:59:15.940][Info] MD5 "" of the image https://static.zerochan.net/full/33/18/2220933.jpg already found in file h:\t\artist-unk src-unk char-unk 20171129 tags- (unknown).jpg

I assume the MD5 value is supposed to be displayed between the pair of double quotes but it looks like Grabber isn't getting an MD5 value from ZeroChan.

P.S. My filename format is quite specific but it does make use of the %md5% token for differentiation. But obviously, with the MD5 value missing, all my filenames appear to be the same for every image.

[Bionus]

Ok, so it seems there's two separate issues at work here:

• [x] Since Zerochan does not provide MD5, Grabber should first save the file with a temporary filename, calculate the file's MD5, then rename it. This seems to be a very similar issue as #925 (you can have more details there). But given that one only seemed to occur on the "Save as" feature it had lower priority. If this also causes issues in batch downloads, I'll move it up my to-do list.
• [x] For some reason, the MD5 list was allowing those empty MD5 and were considering new files as "already existing" basing itself on an empty MD5. Empty MD5 should all be considered as "not present in the MD5 list". I just pushed a fix for that.