Image-sequencer: Problem in extraManipulation

[blurry-x-face]

After #1533 some modules are facing problem because of
https://github.com/publiclab/image-sequencer/blob/2b3e5a2915262acb41cd6a9e39ab4b20807a5eb1/src/modules/_nomodule/PixelManipulation.js#L317
My #1546 was working fine before addition of this code but after its addition it has broken for some reason.
Also many of the tests were also failing ref

We need to fix this soon!

[blurry-x-face]

CC: @HarshKhandeparkar @root00198

[blurry-x-face]

For starters we can do this, it will fix the immediate problem!

[root00198]

I think the issue is that the getDataUri in this line https://github.com/publiclab/image-sequencer/blob/2b3e5a2915262acb41cd6a9e39ab4b20807a5eb1/src/modules/_nomodule/PixelManipulation.js#L317-L322
is an asynchronous call, and the generateOutput is called even before the frame could be set.

[blurry-x-face]

Yes, this seems to be the problem, but I don't think we need to use getDataUri this way, it can be used in some other way, calculating it here when most of the modules don't even require it, this seems useless to me.

[root00198]

Yes I also think that we need to remove it. Only text-overlay module is using this for now, maybe we can generate the dataURI through input in draw function defined in src/modules/TextOverlay/Module.js

[blurry-x-face]

So, Colorbar module is also not working after this!

[blurry-x-face]

And also Resize module.

[blurry-x-face]

Why did the tests pass even though they were not working?

[root00198]

The test didn't passed, I think...

[blurry-x-face]

Yea you're right, tests didn't pass https://travis-ci.org/publiclab/image-sequencer/jobs/638695414#L1970
If that was the case then why was there green tick on travis?

[blurry-x-face]

@jywarren @HarshKhandeparkar

[jywarren]

Oof, thank you, and can we get some reviews on #1551? Looking now, thanks for the discuss and fix!

Also noting https://github.com/publiclab/image-sequencer/pull/1550 and #1427 regarding the Travis green checkmark issues... great catch.