Image-sequencer: Minify-Image module not working

Created on 4 Jan 2020  Â·  7Comments  Â·  Source: publiclab/image-sequencer

Please describe the problem (or idea)

Minify Image module is not showing the output image.

What happened just before the problem occurred? Or what problem could this idea solve?
bug

What did you expect to see that you didn't?
I didnt saw any output image.

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

bug

Most helpful comment

Ah, good catch! Once we figure this out, let's add this to our per-module
tests so that it doesn't happen again :-)

Thank you!!!!

On Mon, Jan 6, 2020 at 6:06 PM Rishabh Shukla notifications@github.com
wrote:

[image: Screenshot from 2020-01-07 04-31-56]
https://user-images.githubusercontent.com/42492389/71855304-aec60800-3106-11ea-89b9-f5b3747667a8.png

Yep! As I thought culprit is most probably one of the very recent PRs as
it is still working on beta site(beta was updated on 29 Dec)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/1420?email_source=notifications&email_token=AAAF6J2HIYRAFFTXPM5D4K3Q4O2NZA5CNFSM4KCX4N52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHC64I#issuecomment-571354993,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6J6M6IGZIGWK4THJDR3Q4O2NZANCNFSM4KCX4N5Q
.

All 7 comments

This was working fine a while back maybe #1425 caused this?
cc: @jywarren

Screenshot from 2020-01-07 04-31-56

Yep! As I thought culprit is most probably one of the very recent PRs as it is still working on beta site(beta was updated on 29 Dec)

Ah, good catch! Once we figure this out, let's add this to our per-module
tests so that it doesn't happen again :-)

Thank you!!!!

On Mon, Jan 6, 2020 at 6:06 PM Rishabh Shukla notifications@github.com
wrote:

[image: Screenshot from 2020-01-07 04-31-56]
https://user-images.githubusercontent.com/42492389/71855304-aec60800-3106-11ea-89b9-f5b3747667a8.png

Yep! As I thought culprit is most probably one of the very recent PRs as
it is still working on beta site(beta was updated on 29 Dec)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/1420?email_source=notifications&email_token=AAAF6J2HIYRAFFTXPM5D4K3Q4O2NZA5CNFSM4KCX4N52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHC64I#issuecomment-571354993,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6J6M6IGZIGWK4THJDR3Q4O2NZANCNFSM4KCX4N5Q
.

I fixed the issue of image not showing.... but the image is not getting compressed, it is stil showing the same image...

Try downloading the image and check its size. It is supposed to reduce the image size (like zipping or tarballing)

I tired tried to find difference between the two images using their's base64 format....Didn't found any.

Maybe the image cannot be compressed? I think we should check what the npm module that is used in the minify-image module, does.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

harshkhandeparkar picture harshkhandeparkar  Â·  5Comments

jywarren picture jywarren  Â·  4Comments

harshkhandeparkar picture harshkhandeparkar  Â·  3Comments

jywarren picture jywarren  Â·  4Comments

kindanduseful picture kindanduseful  Â·  5Comments