Image-sequencer: remove unwanted slider

Created on 12 Mar 2019  路  23Comments  路  Source: publiclab/image-sequencer

Please describe the problem (or idea)

I think there is an unwanted slider (left-right) so I think should remove that slider.
pu4

What happened just before the problem occurred? Or what problem could this idea solve?

What did you expect to see that you didn't?

Please show us where to look

http://sequencer.publiclab.org...

What's your PublicLab.org username?

singhav

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

enhancement has-pull-request

Most helpful comment

phoneversion
It look's cool in my phone @avsingh999
Let's ask the other reviewers @publiclab/is-reviewers is it the thing???

All 23 comments

Does this only occur on small screens? Or also on PC sized screens?

@HarshKhandeparkar Yes there is also slider but In Mobile and not looking good for mobile. In the sense not responsive for mobile we Can in the gif.
thanks : )
pub3

Any ideas which element is causing this?

@avsingh999 I am not able to reproduce the issue.

@avsingh999 you seem to be using an old version of IS. Try rebasing or clearing the cache. If you are using sequencer.publiclab.org then it is ~20days old.

@HarshKhandeparkar even the sequencer.publiclab.org looks good.

@HarshKhandeparkar @Harshithpabbati I getting here sequencer.publiclab.org.Let me see on local machine
thanks : )

@Harshithpabbati @HarshKhandeparkar But I think need to improve for mobile UI.

@jywarren it looks good even in the mobile ui isn't it??

@Harshithpabbati I think the problem in save sequence and view Gif button
thanks : )

phoneversion
It look's cool in my phone @avsingh999
Let's ask the other reviewers @publiclab/is-reviewers is it the thing???

It works fine on my phone as well. Maybe it is resolution dependent? Try it in ur pc browser and try resizing it and try to find out the threshold. Thanks.

Yeah we need the slider for the smaller screens. Or else the view gif will be vanished.

@Harshithpabbati @HarshKhandeparkar yes also working fine in my phone, and I was looking in chrome mobile view so I got this. But slider is still getting in the local machine.
thanks : )

Did you try it on the latest version?

Oh cool! #821 fixes this. I will link to the issue in the pr.

I guess we can close this.

This will be closed when that pr is merged

There is already an issue right?? So we can close it.

Maybe the pr doesn't fix this? No screenshots are provided there. So lets wait

Oh ok

Oh, thanks a million, everyone, for helping solve this!!!

Fixed Elsewhere, I guess.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

harshkhandeparkar picture harshkhandeparkar  路  4Comments

jywarren picture jywarren  路  5Comments

keshav234156 picture keshav234156  路  4Comments

jywarren picture jywarren  路  4Comments

harshkhandeparkar picture harshkhandeparkar  路  5Comments