Image-sequencer: List of UI tasks to be broken out into issues

[jywarren]

Looking for help with these! They could also make good GCI issues @publiclab/mentors !

• [x] change "Save" module button to "Apply"
• [x] change description text above quick-add buttons so it stays as "apply a new step" instead of getting replaced by the last applied module's description (needs gif to demonstrate issue)
• [x] make Image Sequencer header reload the page with no steps
• [x] add a "start a new sequence" button somewhere in header
• [x] add "take a photo" as alternative to "Choose file" in initial load image step
• [x] move "Download PNG" box down onto same line as "Save Sequence" leaving Add Step box full-width
• [x] show spinner icon while gif is generating
• [x] Fix alignment of Add Step button and dropdown next to it
• [x] add toggle-able "collapse" button next to step name (like "load-image") to hide image, description (leaving just the line and the title)
• [x] add Resize module to list of quick buttons, as in this image

Sliders

• [x] make sliders (for range inputs) touch-draggable (using a library) - like brightness
• [x] set brightness default to not be totally white
• [ ] set contrast default to something useful
• [x] set contrast to range slider UI

Save sequence

• [x] have "save sequence" also show a message showing where to find the saved sequence
• [ ] have "save sequence" link to docs showing how to turn a sequence into a meta module
• [x] have "save sequence" link clarify that it will only be available in this browser

[gitmate[bot]]

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/118 (Assorted improvements to be broken into separate issues), https://github.com/publiclab/image-sequencer/issues/165 (Various module ideas to be broken out into separate issues), https://github.com/publiclab/image-sequencer/issues/470 (UI Improvements ), https://github.com/publiclab/image-sequencer/issues/227 (PLANNING ISSUE), and https://github.com/publiclab/image-sequencer/issues/48 (A Semantic Issue).

[gitmate[bot]]

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/118 (Assorted improvements to be broken into separate issues), https://github.com/publiclab/image-sequencer/issues/165 (Various module ideas to be broken out into separate issues), https://github.com/publiclab/image-sequencer/issues/470 (UI Improvements ), https://github.com/publiclab/image-sequencer/issues/227 (PLANNING ISSUE), and https://github.com/publiclab/image-sequencer/issues/48 (A Semantic Issue).

[Rishabh570]

@jywarren Opened this issue for changing "save" to "apply" in add step UI...

[jywarren]

Awesome!

On Thu, Nov 22, 2018, 10:51 AM Rishabh Rawat <[email protected]
wrote:

@jywarren https://github.com/jywarren Opened this
https://github.com/publiclab/image-sequencer/issues/489 issue for
changing "save" to "apply" in add step UI...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/487#issuecomment-441069031,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2x4cuOAfHAxtO8o9Wok5rDy1764ks5uxsfWgaJpZM4Yvb5W
.

[jywarren]

Actually we could make a gci task to break out this list into separate
issues, too! Just an idea :-)

On Thu, Nov 22, 2018, 10:56 AM Jeffrey Warren <[email protected] wrote:

Awesome!

On Thu, Nov 22, 2018, 10:51 AM Rishabh Rawat <[email protected]
wrote:

@jywarren https://github.com/jywarren Opened this
https://github.com/publiclab/image-sequencer/issues/489 issue for
changing "save" to "apply" in add step UI...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/487#issuecomment-441069031,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2x4cuOAfHAxtO8o9Wok5rDy1764ks5uxsfWgaJpZM4Yvb5W
.

[Rishabh570]

@jywarren and they'll be getting credits/points for that?

[jywarren]

I think so, if they're well formatted! We could ask them to post a
screenshot and describe the feature a bit more. Not everyone will be able
to but some are pretty simple.

On Thu, Nov 22, 2018, 12:02 PM Rishabh Rawat <[email protected]
wrote:

@jywarren https://github.com/jywarren and they'll be getting
credits/points for that?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/487#issuecomment-441085680,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ887d0bqMyksQivumozWdZPG8XCLks5uxtiMgaJpZM4Yvb5W
.

[aashna27]

added #491 for "set brightness default to not be totally white"

[aashna27]

should I continue with breaking up or leave it for gci task ?

[Rishabh570]

I think so, if they're well formatted! We could ask them to post a
screenshot and describe the feature a bit more. Not everyone will be able
to but some are pretty simple.

That would be great :+1:

[oorjitchowdhary]

@jywarren @Rishabh570 @aashna27 So is this a GCi task? I may be able to make these into well-formatted issues... We can also use the plots2 repo issue template

[Rishabh570]

Pinging @jywarren for that, you can make these into well formatted into issues...you can get credits/points for it :)

[oorjitchowdhary]

So I can start working right?

[Rishabh570]

Yep, that would be great :+1:

On Sun, 25 Nov, 2018, 16:05 Oorjit Chowdhary <[email protected]
wrote:

So I can start working right?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/487#issuecomment-441430525,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYTX_DTz5imlQqCm0GCOPr-VIQYV8Twdks5uynJxgaJpZM4Yvb5W
.

[oorjitchowdhary]

Added these till now... Pls take a look at them...

1. add "take a photo" as alternative to "Choose file" in initial load image step #494
2. move "Download PNG" box down onto same line as "Save Sequence" leaving Add Step box full-width #493
3. add Resize module to list of quick buttons, as in this image #492

[oorjitchowdhary]

Add some more #495 and #496

[oorjitchowdhary]

Pls take a look and make a task on the gci dash so that i can claim it...
Also, I have to make issues for whole of the list right?

[Rishabh570]

You can create issues out of whole list but it's totally up to you...if you
want to do it or not :)

On Sun, 25 Nov, 2018, 17:42 Oorjit Chowdhary <[email protected]
wrote:

Pls take a look and make a task on the gci dash so that i can claim it...
Also, I have to make issues for whole of the list right?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/487#issuecomment-441435968,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYTX_NNWxo7qpI8nUWqDogxQGUv8aa3sks5uyokvgaJpZM4Yvb5W
.

[oorjitchowdhary]

Ok so I'll be getting credits on the GCI platform right?

[oorjitchowdhary]

Which is the task which is to be claimed here

[oorjitchowdhary]

@jywarren @rishabh570

[Rishabh570]

@oorjitchowdhary You can just create separate issues based on ideas suggested in the issue description and mention this issue if eligible you'll get credits for that...

[jywarren]

Hi, creating a task now! https://codein.withgoogle.com/dashboard/tasks/5897760814399488/

[JonathanXu1]

Hey, I just claimed this task. Would you like me to make a separate issue for each bullet point?

[jywarren]

Sure, if you're able to add something significant to help guide people in
each issue. See, it wouldn't be much better than a list if it were just the
same item. Thanks!!!!

On Mon, Nov 26, 2018, 4:58 PM Jonathan Xu <[email protected] wrote:

Hey, I just claimed this task. Would you like me to make a separate issue
for each bullet point?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/487#issuecomment-441814350,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ64lfsNK_rlKI7NGW8sYPrSVdopPks5uzGPugaJpZM4Yvb5W
.

[JonathanXu1]

Here's an example: https://github.com/publiclab/image-sequencer/issues/498

Would you like it like this?

[jywarren]

this is great. Thanks!!!

On Mon, Nov 26, 2018 at 5:18 PM Jonathan Xu [e-mail]
wrote:

Here's an example: #498
https://github.com/publiclab/image-sequencer/issues/498

Would you like it like this?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/487#issuecomment-441821392,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ_pZ4oXZbmPpYbrrbWzzXkmUQUybks5uzGiagaJpZM4Yvb5W
.

[JonathanXu1]

Another issue: https://github.com/publiclab/image-sequencer/issues/499
For this GCI task to be completed, do I need to make issues for each of the bullet points?

[jywarren]

nope, just one or two is enough! Thank you!

On Mon, Nov 26, 2018 at 5:32 PM Jonathan Xu [e-mail]
wrote:

Another issue: #499
https://github.com/publiclab/image-sequencer/issues/499
For this GCI task to be completed, do I need to make issues for each of
the bullet points?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/487#issuecomment-441826051,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ8nbcCkmUUtKubwfIGH4vqjbNEOpks5uzGvcgaJpZM4Yvb5W
.

[JonathanXu1]

Alright, three's the charm :)
Submitted the task!

[jywarren]

amazing! very well done.

On Mon, Nov 26, 2018 at 5:41 PM Jonathan Xu [e-mail]
wrote:

Alright, three's the charm :)
Submitted the task!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/487#issuecomment-441828589,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJzzbBR2mXu_JTghAd5P5mBWA1BpBks5uzG4EgaJpZM4Yvb5W
.

[oorjitchowdhary]

Added these till now... Pls take a look at them...

1. add "take a photo" as alternative to "Choose file" in initial load image step #494
2. move "Download PNG" box down onto same line as "Save Sequence" leaving Add Step box full-width #493
3. add Resize module to list of quick buttons, as in this image #492

@jywarren @Rishabh570 I have claimed the task on GCI.. And as I mentioned I have already made 5 issues from this list.. So please approve my work at GCI..

[grvsachdeva]

Hi @oorjitchowdhary, all issues looks good, please append the issue number in the checklist so that no-one else opens the same issue. Thanks!

[oorjitchowdhary]

I have mentioned this issue in all of them..

[oorjitchowdhary]

492 #493 #494 #495 #496 all are opened up by me..

[grvsachdeva]

Mention after the above tasks in issue body.

[oorjitchowdhary]

Looking for help with these! They could also make good GCI issues @publiclab/mentors !

• [x] change "Save" module button to "Apply"
• [ ] change description text above quick-add buttons so it stays as "apply a new step" instead of getting replaced by the last applied module's description (needs gif to demonstrate issue)
• [ ] make Image Sequencer header reload the page with no steps
• [ ] add a "start a new sequence" button somewhere in header
• [ ] add "take a photo" as alternative to "Choose file" in initial load image step
• [ ] move "Download PNG" box down onto same line as "Save Sequence" leaving Add Step box full-width
• [ ] show spinner icon while gif is generating
• [ ] Fix alignment of Add Step button and dropdown next to it
• [ ] add toggle-able "collapse" button next to step name (like "load-image") to hide image, description (leaving just the line and the title)
• [ ] add Resize module to list of quick buttons, as in this image

Sliders

• [ ] make sliders (for range inputs) touch-draggable (using a library) - like brightness
• [ ] set brightness default to not be totally white
• [ ] set contrast default to something useful
• [ ] set contrast to range slider UI

Save sequence

• [ ] have "save sequence" also show a message showing where to find the saved sequence
• [ ] have "save sequence" link to docs showing how to turn a sequence into a meta module
• [ ] have "save sequence" link clarify that it will only be available in this browser

You mean to checklist here.. I'm actually unable to edit that

[CodeSarthak]

Hey, I have made 3 separate issues: #513 #512 #511

[oorjitchowdhary]

Hi @codesarthak.. I understand you are trying to complete this gci task.. But I've already opened some issues which you opened up too..

[oorjitchowdhary]

512 is the same as #494 opened by me

513 is the same as #496

Pls open up different issues as duplication of issues leads to a lot of confusion...
Thanks 😃

[CodeSarthak]

Oh @oorjitchowdhary , really very sorry. Actually, I got confused because they were not checked in the checklist. Will pick up some others. : )

[jywarren]

Wow I think these are all done!!! Amazing work, folks!