Image-sequencer: Align box in center in mobile view

[Paarmita]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Problem:

We want the Download PNG and View GIF buttons div in the center in the mobile view.

How to Solve?

You can add responsiveness in the div.

This line can be added below this one.
https://github.com/publiclab/image-sequencer/blob/bf13d5807ab34b04517a3c9d3b4c318342432a48/examples/index.html#L94

Instance Count 1

[gitmate[bot]]

GitMate.io thinks the contributors most likely able to help are @tech4GT, @SidharthBansal, and @gitmate[bot].

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/355 (Adjust/Correct the position of Buttons in Mobile View), and https://github.com/publiclab/image-sequencer/issues/436 (Enhance gif view).

[gitmate[bot]]

GitMate.io thinks the contributors most likely able to help are @tech4GT, @SidharthBansal, and @gitmate[bot].

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/355 (Adjust/Correct the position of Buttons in Mobile View), and https://github.com/publiclab/image-sequencer/issues/436 (Enhance gif view).

[jywarren]

great catch! Actually we may want to have it be on its own line on full
width view as well... but can address this in a follow-up if need be. Thank
you!

On Tue, Nov 20, 2018 at 2:50 AM gitmate[bot] [e-mail]
wrote:

GitMate.io https://gitmate.io thinks the contributors most likely able
to help are @tech4GT https://github.com/tech4GT, @SidharthBansal
https://github.com/SidharthBansal, and @GitMate
https://github.com/GitMate[bot].

Possibly related issues are #355
https://github.com/publiclab/image-sequencer/issues/355 (Adjust/Correct
the position of Buttons in Mobile View), and #436
https://github.com/publiclab/image-sequencer/issues/436 (Enhance gif
view).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/484#issuecomment-440176027,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ9_VvzW2oGfZgpo1-1V5v3zxqO23ks5uw7QLgaJpZM4YqjQf
.

[Rishabh570]

For anybody who would work on it, only removing this would made it sit in the center :)

[lwahlnayar]

Can I give it a go at this? I'm completely new to contributions =)

[Rishabh570]

@lwahlnayar Are you participating in GCI?

[lwahlnayar]

not really...

[Rishabh570]

Actually, this task is for GCI participants...I appreciate that you want to contribute, you can take a look at other open first-timer-only issues here: https://code.publiclab.org/

[lwahlnayar]

alright, thanks!

[JonathanXu1]

Hey there, could I work on this for GCI? This task doesn't seem to be available on the dashboard but I'm also not aware if someone else is working on it...

[Rishabh570]

Yes, you can work on it as it's not claimed by anybody yet...I've created a draft for it, pinging @jywarren for reviewing it and publishing it :)

[JonathanXu1]

@Rishabh570 great, I've centered the div in #502.

[jywarren]

published!

On Tue, Nov 27, 2018 at 3:27 PM Jonathan Xu [e-mail]
wrote:

@Rishabh570 https://github.com/Rishabh570 great, I've centered the div
in #502 https://github.com/publiclab/image-sequencer/pull/502.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/484#issuecomment-442204842,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJxIn16Lzr1j4xPJVLys6a-HdAt5Kks5uzZ_-gaJpZM4YqjQf
.

[JonathanXu1]

Is there a link?

[Rishabh570]

@JonathanXu1 Here is the link: https://codein.withgoogle.com/dashboard/task-instances/4889843105529856/

[JonathanXu1]

Oh it seems like this is a beginner task. My bad.

[jywarren]

Someone has claimed this in GCI and needs to post a pull request still. I requested more work, and we'll see if we hear back. Thanks everyone! 👍

[AmanGarg97]

Hey! Can I work on this? It's my first contribution on image-sequencer.

[harshkhandeparkar]

@AmanGarg97, sure! That will be awesome. But are you new to an issue like this? If you have solved such other issues before then you can leave this one for some first timer and solve some other one maybe?

[VibhorCodecianGupta]

@AmanGarg97 I think you can take this one up since you are contributing to Image Sequencer for the first time, familiarise yourself with the code base.
@HarshKhandeparkar I think this is a good fto issue, let's let first-timers work on this, cheers!

[harshkhandeparkar]

@AmanGarg97 I think you can take this one up since you are contributing to Image Sequencer for the first time, familiarise yourself with the code base.
@HarshKhandeparkar I think this is a good fto issue, let's let first-timers work on this, cheers!

What I felt was that someone like @AmanGarg97 can get acquainted with the codebase easily but someone a bit less experienced might take more time. So someone who is new to github and PRs etc. can take up this issue maybe? @VibhorCodecianGupta what do you say?

[harshkhandeparkar]

@VibhorCodecianGupta maybe @AmanGarg97 can take up an intermediate level issue maybe? This can be fixed too! @AmanGarg97 what do you want to do? Will you be able to fix something a bit more difficult than this? Or do you want to fix this? Welcome to the image-sequencer community :tada: :tada:

[AmanGarg97]

@VibhorCodecianGupta @HarshKhandeparkar I can start with this but it would also be best if you can assign some another issue so that I can go through the codebase and can start contributing to this.
Thanks!

[AmanGarg97]

Hey please review #669 and let me know for any other changes.

[AmanGarg97]

Also are there any proper Contributions Guidelines for the project?
What I faced was:

1. How to install the project in Linux environment for a newbie.
   2.What are the steps to solve an issue and make a PR (branching and all that stuff).

If there is not then I will love to make one.
Thanks!

[tech4GT]

I think we have a setup script Aman, try running npm run setup and then npm run start

[harshkhandeparkar]

@jywarren @gauravano @Paarmita I think this is not required due to recent changes

But there is a PR open for it https://github.com/publiclab/image-sequencer/pull/669

[grvsachdeva]

Thanks @HarshKhandeparkar for the update! Closing this issue for now, feel free to open if necessary. Thank you @AmanGarg97 for working on it, really appreciated :100: .