Image-sequencer: Bug in example/lib/defaultHtmlStepUi.js

Created on 18 Nov 2018  路  8Comments  路  Source: publiclab/image-sequencer

Flash Message During Step Removal Typo Bug

gci-bug

https://github.com/publiclab/image-sequencer/blob/bf13d5807ab34b04517a3c9d3b4c318342432a48/examples/lib/defaultHtmlStepUi.js#L19

DOMNotification is not defined and is a typo

HTML bug documentation

Most helpful comment

Actually, we can talk here only:

@HarshKhandeparkar thanks so much for your enthusiasm in the weekly check-in! Sorry we made some last minute changes, but we thought it over a bit and felt that a) we worried that some memes might end up making people feel bad, even by accident, and b) we have a strong need for reviewers anyways. I hope this makes sense why we deleted your comment from weekly check-in and didn't want this to be discouraging - we are super grateful for your help in collaboratively hosting the community. Thanks so much for your time and keep up the great work!

All 8 comments

Thanks for opening your first issue here! Please follow the issue template to help us help you 馃憤馃帀馃槃
If you have screenshots to share demonstrating the issue, that's really helpful! 馃摳 You can make a gif too!

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/408 (Typo in info.json), https://github.com/publiclab/image-sequencer/issues/401 (Typo in CONTRIBUTING.MD), and https://github.com/publiclab/image-sequencer/issues/25 (Issues With ImageManipulation.js).

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/408 (Typo in info.json), https://github.com/publiclab/image-sequencer/issues/401 (Typo in CONTRIBUTING.MD), and https://github.com/publiclab/image-sequencer/issues/25 (Issues With ImageManipulation.js).

hey @HarshKhandeparkar, could you please give your Email ID?

Why do you need by Email ID?

Actually, we can talk here only:

@HarshKhandeparkar thanks so much for your enthusiasm in the weekly check-in! Sorry we made some last minute changes, but we thought it over a bit and felt that a) we worried that some memes might end up making people feel bad, even by accident, and b) we have a strong need for reviewers anyways. I hope this makes sense why we deleted your comment from weekly check-in and didn't want this to be discouraging - we are super grateful for your help in collaboratively hosting the community. Thanks so much for your time and keep up the great work!

Oh Np. Even I thought I would delete my comment but you had already done that. I was hesitant to comment at first but I saw your comment and I thought it won't be much of an awkward thing. But anyways, thank you, Np, welcome etc. 馃槉

Great!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jywarren picture jywarren  路  3Comments

jywarren picture jywarren  路  5Comments

blurry-x-face picture blurry-x-face  路  4Comments

harshkhandeparkar picture harshkhandeparkar  路  4Comments

VladimirMikulic picture VladimirMikulic  路  3Comments