Image-sequencer: add placeholder when brightness step applied

[rockstar777]

First Timers Only

Hi, this is a first-timers-only issue. This means this has been worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Problem

Add placeholder like percentage that is applied when brightness step is applied.

The Solution

The above code can be found in https://github.com/publiclab/image-sequencer/blob/main/examples/lib/defaultHtmlStepUi.js
try to put placeholder in input element with its corresponding value.
value can be found in step.options

best of luck for the first PR :tada: :tada:

[gitmate[bot]]

GitMate.io thinks possibly related issues are https://github.com/publiclab/image-sequencer/issues/113 (Add a Brightness module), https://github.com/publiclab/image-sequencer/issues/344 (Add a function to create a gif from the outputs of all steps), https://github.com/publiclab/image-sequencer/issues/250 (Add step.toString() and sequencer.toString() methods), https://github.com/publiclab/image-sequencer/issues/303 (Disable/dim the Add step button until a module is selected), and https://github.com/publiclab/image-sequencer/issues/269 (Prior steps need not re-run when a new module is added or deleted).

[gitmate[bot]]

GitMate.io thinks possibly related issues are https://github.com/publiclab/image-sequencer/issues/113 (Add a Brightness module), https://github.com/publiclab/image-sequencer/issues/344 (Add a function to create a gif from the outputs of all steps), https://github.com/publiclab/image-sequencer/issues/250 (Add step.toString() and sequencer.toString() methods), https://github.com/publiclab/image-sequencer/issues/303 (Disable/dim the Add step button until a module is selected), and https://github.com/publiclab/image-sequencer/issues/269 (Prior steps need not re-run when a new module is added or deleted).

[kostadriano]

Hi, Can I claim this issue?

[rockstar777]

sure! Go ahead

[kostadriano]

for me to be sure, what you need is a placeholder with an example like this?

[rockstar777]

Yes, It should display when we apply step UI, so that user could get data used when adding a step

[kostadriano]

https://github.com/publiclab/image-sequencer/pull/370

[wptechprodigy]

Is this still up for grabs?

I want to work on it right away.

[wptechprodigy]

defaultHTMLStepUi.js seem to be empty after I had forked, cloned and view it with vim on my Termux CLI

[wptechprodigy]

What could be the cause?

[rockstar777]

I think it is merged, try to find another issue.
It should not be empty but may due some cloning error.
Try to open it in different text editor, may be it works.
Thanks for your interest.
keep contributing