Image-sequencer: 'No file chosen' wrongly placed in Import Image module

[Paarmita]

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

First Timers Only

Hi, this is a first-timers-only issue. This means this has been worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Problem

'No file chosen' option in import image module is misplaced, ie. out of the box

The Solution

We need to modify css such that it comes inside border or under Choose file button.
The line which needs to be mdified is:

https://github.com/publiclab/image-sequencer/blob/88364decf6a6111a0be31fd98010576d5c6f918e/src/modules/ImportImage/Ui.js#L16

https://github.com/publiclab/image-sequencer/blob/88364decf6a6111a0be31fd98010576d5c6f918e/src/modules/ImportImage/Ui.js#L11

You need to add class to it and add the new css for the specific class.

Instance Count = 1

[gitmate[bot]]

GitMate.io thinks the contributors most likely able to help are @tech4GT, and @gitmate[bot].

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/5 (image cropping module), https://github.com/publiclab/image-sequencer/issues/116 (Image overlay module), https://github.com/publiclab/image-sequencer/issues/233 (Add an "import image" module), https://github.com/publiclab/image-sequencer/issues/141 (move module tests into separate test files), and https://github.com/publiclab/image-sequencer/issues/108 (Math Module).

[gitmate[bot]]

GitMate.io thinks the contributors most likely able to help are @tech4GT, and @gitmate[bot].

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/5 (image cropping module), https://github.com/publiclab/image-sequencer/issues/116 (Image overlay module), https://github.com/publiclab/image-sequencer/issues/233 (Add an "import image" module), https://github.com/publiclab/image-sequencer/issues/141 (move module tests into separate test files), and https://github.com/publiclab/image-sequencer/issues/108 (Math Module).

[vikul1234]

@Paarmita It's work properly look this, can you post another screenshot

[Paarmita]

@vikul1234 Plz add an import image module, then you will be able to reproduce this.

[tech4GT]

This issue has been reserved for GCI @vikul1234
We would really appreciate your help on another one which is not labelled gci. Thanks!!

[jywarren]

This is a great issue - @Paarmita thanks! Maybe one addition is that you can link to a page including the import-image module using a permalink:

http://sequencer.publiclab.org/examples/#steps=import-image

[Paarmita]

@jywarren Yup! we can do that as well.

[SidharthBansal]

This task is published on GCI dashboard. Thanks all.

[makoteq]

what we have to give in response on GCI?
Please i need help!🤔

[JonathanXu1]

@makoteq I believe this task has either not appeared on GCI, someone already claimed it, or it was completed but not closed.

[oorjitchowdhary]

@Paarmita @jywarren @SidharthBansal Has this issue been already solved? I can't find any PRs related to this

[jywarren]

If there hasn't been a PR, i think it is still open. Do you see the
described design in the demo? Thanks!

On Wed, Nov 28, 2018 at 1:57 PM Oorjit Chowdhary [e-mail]
wrote:

@Paarmita https://github.com/Paarmita @jywarren
https://github.com/jywarren @SidharthBansal
https://github.com/SidharthBansal Has this issue been already solved? I
can't find any PRs related to this

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/356#issuecomment-442563457,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJxg7tZ93VuuVRHXyrusacXl3Z_rMks5uztyGgaJpZM4XAl1f
.

[adiwahyudi02]

Can I take this issue? @jywarren @Paarmita

[harshkhandeparkar]

Seems like this is redundant and has been fixed elsewhere and is outdated. Can this be closed? @jywarren @gauravano

[Paarmita]

@HarshKhandeparkar Thanks for the review.

[grvsachdeva]

This issue is not required as there is a change in page design. Thanks @HarshKhandeparkar @Paarmita !

[harshkhandeparkar]

Maybe we can open a new fto though as it is not working for smaller screens

Import-image:

Load-image first step:

[grvsachdeva]

Sure! Go ahead!

On Mon, Jan 21, 2019 at 12:34 AM Harsh Khandeparkar <
[email protected]> wrote:

Maybe we can open a new fto though as it is not working for smaller
screens

Import-image:

[image: screenshot_20190121_003315_com android chrome]
https://user-images.githubusercontent.com/34770591/51443792-4ffc5880-1d14-11e9-8ecb-7cd27b2f5178.jpg

Load-image first step:

[image: screenshot_20190121_003318_com android chrome]
https://user-images.githubusercontent.com/34770591/51443793-5b4f8400-1d14-11e9-9ac8-1748fd59d015.jpg

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/356#issuecomment-455892960,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT6S9lYDcOQrcorT3KQAYJMre59NhPq8ks5vFL3XgaJpZM4XAl1f
.

[harshkhandeparkar]

Ok. Will do that sometime.