Igniteui-angular: `headerGroupClasses` is marked as hidden

Created on 12 Mar 2019  路  9Comments  路  Source: IgniteUI/igniteui-angular

Description

headerGroupClasses is marked as hidden so that our doc does not show it.

  • igniteui-angular version: 7.2.0
  • browser: n/a

Steps to reproduce

  1. See the source code - https://github.com/IgniteUI/igniteui-angular/blob/master/projects/igniteui-angular/src/lib/grids/column.component.ts#L347-L351

Result

headerGroupClasses is marked as hidden.

Expected result

headerGroupClasses is not marked as hidden.

Attachments

Attach a sample if available, and screenshots, if applicable.

bug in-review resolved typedoc 7.1.x 7.2.x

All 9 comments

@ymita What's the reasoning of this request? I believe this property is hidden on purpose, not by mistake.

@mpavlinov
A customer would like to use this property for group header. Can we make this property available for customer developers?

@ymita I see, but what is the use case he's trying to achieve? Is it a styling issue that we don't cover with our theming functionality?
Maybe the solution for the customer is not opening up the private property. That's what I'm trying to understand.

I believe the customer wants to align the text of group column header to center.
Mihoko achieved this requirement by using headerGroupClasses input like so:

<igx-column-group ... headerGroupClasses="app-group-column-header">
....
</igx-column-group>
.app-group-column-header > div.igx-grid__thead-title {
      justify-content: center !important;
}

StackBlitz sample with ViewEncapsulation.None

StackBlitz sample without ViewEncapsulation.None

If we want to do it in "the right way", we may consider creating of a multi-header-text-align property that can help us to achieve this by using grid schema

@ymita, using of schemas is the official and declarative way to define all properties a component theme might use.

@simeonoff, could you share your expert opinion on that matter?

@zdrawku If the target is to have custom headers, different from the default ones, I'd suggest using custom header templates.

As we discussed with @SAndreeva, we are going to expose headerGroupClasses, the purpose of this input is to provide a class selector of the Grouped headers, such as headerClasses input which is used to get/set class selector of the Column header.

Related PR

headerGroupClasses is now available from the API docs

@zdrawku
Thanks. Now I see headerGroupClasses is available on the 7.1.10 doc. Is this also available on the 7.2.1 doc as well?

The PR was merged 4 days ago, which means it will be available in 7.2.2 version which we will release today.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jdk339 picture jdk339  路  3Comments

nikunjgajera picture nikunjgajera  路  3Comments

Hypenate picture Hypenate  路  3Comments

ViktorSlavov picture ViktorSlavov  路  3Comments

Hypenate picture Hypenate  路  3Comments