Ignite: `ignite new` fails when project name consists entirely of numbers

Created on 23 Jul 2017  Â·  2Comments  Â·  Source: infinitered/ignite

When creating an ignite project in a project directory that consists entirely of numbers:

ignite new 100

creation fails with the message

✖ failed to add React Native 0.42.0
bug help wanted

Most helpful comment

@jamonholmgren will give this a shot when I can!

All 2 comments

Good opportunity for new OS contributors

This one should be relatively straightforward to detect and fix. Let's not allow all-number project names.

For someone who wants to try this:

Set up Ignite for development.

Create the check in this file, right below (and very similar code to) this block:

https://github.com/infinitered/ignite/blob/master/src/commands/new.js#L43-L48

Also write a test similar to this one:

https://github.com/infinitered/ignite/blob/master/tests/fast/cli/cliEmpty.test.js#L25-L40

Maybe rename that file as cliMalformed.test.js and just add the other test in that same file.

Ping me in the Infinite Red Community Slack if you run into problems.

@jamonholmgren will give this a shot when I can!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rammmukul picture rammmukul  Â·  3Comments

shawn-tangsc picture shawn-tangsc  Â·  3Comments

vesper8 picture vesper8  Â·  3Comments

NikitaVr picture NikitaVr  Â·  3Comments

GantMan picture GantMan  Â·  3Comments