Thoughts on removing Fastlane from the generated code? IMO it's too opinionated. There are plenty of other services one may wish to choose from, including Buddybuild, Bitrise, etc. and I feel it should be up to the implementation to make the CI decision without leading them. I hope you agree.
I do. We'll need to move fastlane to a generator, and then we can remove. So it could be ignite generate fastlane which would be useful, and even friendly to other possibilities.
I'll mark this as a TODO/EASY and hope someone picks up the PR soon. If not, I will def get it eventually.
Solid. Thanks 馃憣馃徏
This is now gone. But could rise from the ashes as a plugin!
Ahw! I personally disagree with @jhabdas his statement _"IMO it's too opinionated"_. That would mean everything should go, as it's all opinionated. I mean, redux? The navigation library? Apisauce?
Not that long ago, ignite included react-native-router-flux, which got replaced with react-navigation. I don't understand why, but I trust that this decision was made by people that know the react-native playing ground better than I do.
The reason I started using ignite was _because_ it was opinionated. It's an excellent starting ground from a to z. I just realized fastlane was missing and it's a little disappointing imo.
Anyway, just my thoughts on the matter :)
Update: I finally found out why react-native-router-flux got replaced and I'm glad they did.
I personally disagree with @jhabdas his statement "IMO it's too opinionated"
The wonderful thing about opinion, and feelings in general, is they cannot be disagreed with. Because they're not facts. Nevertheless, leading implementations on CI approach or authentication, can stymie innovation and lead to potential security risks down the line.
That said, my understanding is CI is a deployment concern, and not something an asset pipeline should necessarily be implementing. But that's just my opinion.
Would be cool to see FastLane come back as a plug-in, as @skellock mentions is a future possibility. And I'd personally love to see one for Buddy as well.
The wonderful thing about opinion and feelings is they cannot be disagreed with.
What I meant, was that I don't share your opinion. Which.. Is disagreeing? So, I _can_ disagree with your opinion. Which I do. And I think providing an opinionated and complete bundle, is useful. Even CI. It being moved to a generator, but at least pointed out would have made more sense. Now it's just removed, with no generator.
I believe what you're trying to say is that you disagree with the outcome of this issue and would prefer to see a more opinionated solution for building your apps. Perhaps Pepperoni or Snowflake have the kind of opinion you desire. Otherwise the plug-in system is the way to go. Extensible and enables BYOO, Bring Your Own Opinion.
Also, just for fun, if I told you "It's my opinion that I can levitate," would you disagree with me? Or would you thank me for sharing and choose to go your own way?
Yes, I would disagree with you. Because I would have a different opinion. Which is what a disagreement is. English isn't my first language, but I know it well enough to know that you're wrong. :p
Semantics aside, we agree that a plugin system is the way to go. But the "full-blown" option the cli offers now doesn't include fastlane anymore, there's no plugin, it's just gone. It's (as far as I could see) not document anywhere besides this issue. I think that's a shame for newcomers.
Thanks for mentioning Buddybuild by the way, I just checked it out and it looks pretty cool! :)
Haha. Fair enough. Buddybuild was the reason I opened this issue. My argument Fastlane was too complex had more to do with its crappy subpar CX (Customer Experience) than anything.
It's possible to use Buddy together with Fastlane (some are), but for getting, ahem, _Ignited_, BB is the way to go for CI in RN apps at the moment.
Here is a quick post I wrote on my experience with it:
https://habd.as/beta-testing-react-native-buddybuild/
Here's an example integration:
https://github.com/jhabdas/lumpen-radio
And here's how to hide all your secrets:
http://stackoverflow.com/questions/33117227/setting-environment-variable-in-react-native/39645159#39645159
Have fun out there!
I'm looking forward to plugins for both these options. If either of you are interested in learning how to write em, let me know! I'd love to help, and it's super easy.
@ryanlntn - We'll need to explore do one of these when we release the Chain React conference app in a bit.
@GantMan I'm curious. Perhaps @jhabdas can help out since he already has experience with it (and an example integration). I'd like to learn more about it.
@RWOverdijk @GantMan I'll give a CI plug-in a shot next RN app I make. 馃憤
Most helpful comment
I do. We'll need to move fastlane to a generator, and then we can remove. So it could be
ignite generate fastlanewhich would be useful, and even friendly to other possibilities.I'll mark this as a TODO/EASY and hope someone picks up the PR soon. If not, I will def get it eventually.